Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

176 java.lang.ClassCastException when a method accepts an array as a second argument #177

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Sep 30, 2024

Description

Found bug when the array is the second argument of the method being called.
We also felt that the error messages were not clear enough

Related Issue

Fixes #176

How Has This Been Tested?

manual and auttomatic

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (7153510) to head (3d08b05).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #177      +/-   ##
============================================
+ Coverage     92.30%   92.57%   +0.27%     
- Complexity      289      291       +2     
============================================
  Files            26       26              
  Lines           793      795       +2     
  Branches         69       69              
============================================
+ Hits            732      736       +4     
+ Misses           47       46       -1     
+ Partials         14       13       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@baubakg baubakg merged commit 0fb53e8 into main Sep 30, 2024
10 checks passed
@baubakg baubakg deleted the 176-javalangclasscastexception-when-a-method-accepts-an-array-as-a-second-argument branch September 30, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.ClassCastException when a method accepts an array as a second argument
1 participant