Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a plugin system for deserializing internal objects #163

Merged

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented Sep 11, 2024

Description

We an now define a plugin for extracting specific object types.

Related Issue

Fixes #160

Motivation and Context

Allowing users

How Has This Been Tested?

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@baubakg baubakg linked an issue Sep 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (55bc366) to head (d266890).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ampaign/tests/bridge/service/IBSPluginManager.java 94.11% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #163      +/-   ##
============================================
+ Coverage     92.03%   92.16%   +0.13%     
- Complexity      283      285       +2     
============================================
  Files            25       26       +1     
  Lines           741      779      +38     
  Branches         65       68       +3     
============================================
+ Hits            682      718      +36     
- Misses           45       47       +2     
  Partials         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@baubakg baubakg merged commit 26daf24 into main Sep 11, 2024
9 of 10 checks passed
@baubakg baubakg deleted the 160-create-a-plugin-system-for-deserializing-internal-objects branch September 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a plugin system for deserializing internal objects
1 participant