Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 79 - Managing secrets and dealing with headers #121

Merged
merged 8 commits into from
May 4, 2024

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented May 4, 2024

Description

Related Issue

Resolves #79

Motivation and Context

We have discovered that it is not always safe to pass secrets in the json payload.

How Has This Been Tested?

  • unit tests
  • integration tests
  • manual tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

@baubakg baubakg linked an issue May 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (a06cb6f) to head (5dac654).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #121      +/-   ##
============================================
+ Coverage     90.36%   91.06%   +0.70%     
- Complexity      239      262      +23     
============================================
  Files            24       25       +1     
  Lines           633      683      +50     
  Branches         57       57              
============================================
+ Hits            572      622      +50     
  Misses           47       47              
  Partials         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented May 4, 2024

@baubakg baubakg merged commit bbc2f74 into main May 4, 2024
10 checks passed
@baubakg baubakg deleted the 79-variables-in-headers-avoid-secrets-in-the-payload branch May 4, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables in headers : Avoid secrets in the payload
1 participant