Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: e2e fixes for list tests #197

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented Oct 16, 2024

Description

  • add a test for .list() bug ? #194. This has been used to test a fix locally.
    Note to reviewers: there is a trade-off here as this test considerably increases the execution time (from .5 minutes to 2.5 minutes on my local machine) on the deployment path too.
    This is now tested via a unit test on the server.

  • stabilize list e2e tests and improve helper functions

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2ce4a07) to head (2549cef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          272       272           
  Branches        47        47           
=========================================
  Hits           272       272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moritzraho moritzraho changed the title chore: e2e tests for list, large dataset test and fixes chore: e2e fixes for list tests Oct 17, 2024
@moritzraho moritzraho force-pushed the chore/e2e-tests-list-improvements branch from d2fb370 to b1659f3 Compare October 17, 2024 10:52
@moritzraho moritzraho merged commit d9d930c into main Oct 21, 2024
8 checks passed
@moritzraho moritzraho deleted the chore/e2e-tests-list-improvements branch October 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants