Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have successfully made all the reviews div responsive ! #570

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

2004pra
Copy link
Contributor

@2004pra 2004pra commented Oct 12, 2024

Issues indentification_> the issue was that the divs for the review section in website were not responsive so i change a bit of code and made them responsive!

Closes: #537

Summary

first : i change the height of all divs and set them to 100%
second : then i make the padding to 2rem
thats all how i did it !

Details

--> i followed the contributing steps carefully and followed them.
-> i have also taken help from the community manager on pathsphere discord to complete it as fast as posssible and in a
perfect manner .

Types of Changes

Please check the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Please check the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes do not break the current system and pass all existing test cases
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots

first it was like this ->
Screenshot 2024-10-12 002930
now all 3 are responsive ->
Screenshot 2024-10-12 235642

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for pathsphere ready!

Name Link
🔨 Latest commit 5ebaa5a
🔍 Latest deploy log https://app.netlify.com/sites/pathsphere/deploys/670abfacc025450008f5c768
😎 Deploy Preview https://deploy-preview-570--pathsphere.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, 2004pra, for creating this pull request and contributing to Pathsphere! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@aditya-bhaumik aditya-bhaumik merged commit 9f33524 into aditya-bhaumik:main Oct 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The size of 3rd reviews div is not correct !
2 participants