Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Radio 2 and events live stream #685

Merged
merged 1 commit into from
Mar 7, 2020

Conversation

dagwieers
Copy link
Collaborator

It appears Radio 2 works as well using a vualto-radio2 id, and we can
also add Radio 1.

@dagwieers dagwieers added the enhancement New feature or request label Jan 31, 2020
@dagwieers dagwieers added this to the v2.4.0 milestone Jan 31, 2020
@mediaminister
Copy link
Collaborator

mediaminister commented Jan 31, 2020

It seems vualto_radio1 stream is starting much slower than vualto_events3_geo. I get the following errors:

2020-01-31 13:22:02.520 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:03.520 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:03.521 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:03.521 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:03.567 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:04.568 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:04.568 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:04.568 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:04.610 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:05.611 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:05.611 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:05.611 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:05.648 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:06.648 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:06.648 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:06.648 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:06.684 T:140518824802432   DEBUG: ------ Window Deinit (Pointer.xml) ------
2020-01-31 13:22:06.700 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:07.700 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:07.700 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:07.700 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:07.733 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:08.733 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:08.734 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:08.734 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:08.772 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:09.773 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:09.773 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:09.773 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:09.812 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:10.812 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:10.812 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:10.812 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:10.849 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:11.849 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:11.850 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:11.850 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:11.893 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415
2020-01-31 13:22:12.893 T:140516205250304   DEBUG: AddOnLog: InputStream Adaptive: AdaptiveStream: trying to reload segment ...
2020-01-31 13:22:12.894 T:140516205250304   DEBUG: CurlFile::ParseAndCorrectUrl() adding custom header option 'connection: keep-alive'
2020-01-31 13:22:12.894 T:140516205250304   DEBUG: CurlFile::Open(0x7fcc50040800) https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash
2020-01-31 13:22:12.931 T:140516205250304   ERROR: AddOnLog: InputStream Adaptive: Download https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/dash/live-text_track_0_dut=1000-1580473293440.dash failed with error: 415

@dagwieers
Copy link
Collaborator Author

I noticed that as well, and it was the reason for not merging it right away. I wanted to test this on another device first.

@dagwieers
Copy link
Collaborator Author

I had not seen the errors before, so 415 is Unsupported Media Type again?

@mediaminister
Copy link
Collaborator

mediaminister commented Jan 31, 2020

Yes, Unsupported Media Type, there must be something wrong with this stream. I tried playing the stream https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/.mpd with https://www.jwplayer.com/developers/stream-tester/ and I also got an error.

Same 415 error with

ffmpeg -i "https://live-radio-cf.lwc.vrtcdn.be/groupa/live/d6fdec5d-5d67-4cc3-9f8c-e3e8993c8ee4/live.isml/.mpd"
[https @ 0x55a539b87880] HTTP error 415 Unsupported Media Type
[dash @ 0x55a539a50e00] Failed to open fragment of playlist 0

VRT should fix this, this error is documented in the Unified Streaming Platform docs:

You might experience '415 unsupported media type' errors when a multi-bitrate stream is not keyframe-aligned.

https://docs.unified-streaming.com/documentation/vod/troubleshooting.html#unsupported-media-type

We experienced this error earlier with some VOD content: #307 (comment)

So, we should keep vualto_events3_geo for now.

@dagwieers
Copy link
Collaborator Author

Sure, let's keep this open for now.

@dagwieers
Copy link
Collaborator Author

dagwieers commented Feb 2, 2020

I reported this issue to VRT NU, let's see what they say about it.

Update: They replied this is not related to VRT NU. Need to report it to VRT instead.

@dagwieers
Copy link
Collaborator Author

I am going to merge this as this adds the extra Events streams (which includes the rugby match between Belgium and Spain on Events 2 stream)

@dagwieers dagwieers modified the milestones: v2.4.0, v2.3.3 Mar 7, 2020
@dagwieers dagwieers changed the title Add Radio 2 live stream Add Radio 2 and events live stream Mar 7, 2020
@dagwieers dagwieers force-pushed the radio2-live branch 3 times, most recently from d4bfa2a to 1155c31 Compare March 7, 2020 15:05
@dagwieers
Copy link
Collaborator Author

dagwieers commented Mar 7, 2020

The web scraper seems broken again. I am going to look at the webscraper this evening.

@mediaminister
Copy link
Collaborator

mediaminister commented Mar 7, 2020

There were just two more problems with unit tests. Fixed in #693

It appears Radio 2 works as well using a vualto-radio2 id, and we can
also add Radio 1.
@mediaminister mediaminister merged commit ee7ef5f into add-ons:master Mar 7, 2020
@add-ons add-ons deleted a comment from codecov-io Apr 27, 2020
@dagwieers
Copy link
Collaborator Author

Since the VRT Events 3 stream no longer carries the Radio 1 live stream, I tried a third attempt at contacting VRT to report the HTTP 415 Unsupported Media Type error using https://www.vrt.be/nl/heb-je-een-vraag/

I will create a PR to make vualto_radio1 the default stream for Radio 1 live stream, even when it starts to play with an 11 seconds daly 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream slow starts with HTTP 415 on subtitle track
2 participants