Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between Label and Title #668

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Differentiate between Label and Title #668

merged 1 commit into from
Jan 11, 2020

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented Jan 9, 2020 •
edited
Loading

This PR includes:

  • Clear distinction between Label and Title
  • Add get_title() metadata function
  • Add get_mediatype() metadata function
  • Set proper mediatype for oneoff videos
  • Add FIXMEs for a known label/title issue in Kodi/Estuary

@dagwieers dagwieers added the enhancement New feature or request label Jan 9, 2020
@dagwieers dagwieers added this to the v2.3.1 milestone Jan 9, 2020
@dagwieers dagwieers force-pushed the originaltitle branch 3 times, most recently from d05763e to 33f85c1 Compare January 9, 2020 04:44
@dagwieers
Copy link
Collaborator Author

dagwieers commented Jan 9, 2020 •
edited
Loading

@mediaminister We seem to have issues with web scraping again. Maybe due to changes to the VRT NU website ?

@mediaminister
Copy link
Collaborator

Indeed, the livestream player is removed from the channel pages of Eén en Canvas (https://www.vrt.be/vrtnu/kanalen/een/ https://www.vrt.be/vrtnu/kanalen/canvas/)
I still have to investigate the impact on the add-on, I expect there could be a problem watching Eén and Canvas live from the TV guide menu.
I'll provide a fix as soon as possible.

@dagwieers
Copy link
Collaborator Author

dagwieers commented Jan 9, 2020 •
edited
Loading

A few remarks:

  • This PR without a change to Kodi has no real impact (except maybe code clarity)
  • Using sorttitle does not seem to have any effect on sorting
  • As such there is no real difference to sorting by Name or by Title

@dagwieers dagwieers force-pushed the originaltitle branch 2 times, most recently from 949c21b to aeb0fe0 Compare January 9, 2020 15:58
@mediaminister
Copy link
Collaborator

@dagwieers I think the problem you are trying to fix is situated here: https://github.com/pietje666/plugin.video.vrt.nu/blob/07619e8a5c877b6d7d237d76203c910c23245ec8/resources/lib/apihelper.py#L236

@dagwieers
Copy link
Collaborator Author

dagwieers commented Jan 9, 2020 •
edited
Loading

Oh damn 😱

However, if I remove that line, my label has the title, not the label. from ListItem. Are we somewhere modifying the label to become the title? I have no clue why we did the above either :-/

Same for tvguide. It seems as if Estuary is showing the Title in the listing, and not the Label.
https://github.com/pietje666/plugin.video.vrt.nu/blob/07619e8a5c877b6d7d237d76203c910c23245ec8/resources/lib/tvguide.py#L184

@mediaminister
Copy link
Collaborator

I found the cause, xbmcplugin.addSortMethod is messing things up.

@dagwieers
Copy link
Collaborator Author

I found the cause, xbmcplugin.addSortMethod is messing things up.

Yes, I can reproduce this now. Thanks, it would have taken me some time to find this 🙄

@dagwieers dagwieers force-pushed the originaltitle branch 2 times, most recently from 9ca4c84 to 1b12463 Compare January 9, 2020 19:45
@dagwieers
Copy link
Collaborator Author

dagwieers commented Jan 9, 2020 •
edited
Loading

So this PR works as expected but without any sort methods... 😞

@dagwieers dagwieers force-pushed the originaltitle branch 3 times, most recently from e81dfad to e4ae18a Compare January 10, 2020 16:06
@dagwieers
Copy link
Collaborator Author

The current PR is ready to be merged, but doesn't fix the original issue I intended to fix. But at least we understand better what is going on and where the fix is needed. I added 2 FIXMEs in the code to highlight this.

@dagwieers dagwieers changed the title Differentiate Label and Title Differentiate between Label and Title Jan 11, 2020
@dagwieers
Differentiate Label and Title
59503dd 
This PR includes:
- Clear distinction between Label and Title
- Add `get_title()` metadata function
- Add `get_mediatype()` metadata function
- Set proper mediatype for oneoff videosdd FIXMEs for a known
- Add FIXMEs for a known label/title issue in Kodi/Estuary
@dagwieers
Copy link
Collaborator Author

Going to merge this as it adds various small visual improvements. We can improve on this later (especially if we want to improve oneoffs wrt. #670).

@dagwieers dagwieers merged commit f9a14de into add-ons:master Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dagwieers @mediaminister