Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Transcript Update (fixes: issue/35) #36

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Update: Transcript Update (fixes: issue/35) #36

merged 7 commits into from
Sep 12, 2024

Conversation

joe-replin
Copy link
Contributor

@joe-replin joe-replin commented Aug 29, 2024 •
edited
Loading

Fix

Update

  • This component has a subView for some reason. Not entirely sure why. I needed to lift the transcript button back into the primary view & primary template in order for the skipToTranscript button to appropriately assign focus to it.
  • Brings this component and the approach with the transcript button to be more in-line with the modern Media Component
  • Removes Transcript-only JS & HBS files.
  • Transcript logic moved into View.
  • Transcript styles updated
  • Transcript template merged into component template

Testing

  1. Add plug-in to project
  2. using keyboard navigation & a screen reader, test that the Skip To Transcript button is working appropriately and that the transcript button is behaving as it should.

@joe-replin joe-replin added the bug label Aug 29, 2024
@joe-replin joe-replin self-assigned this Aug 29, 2024
@joe-replin joe-replin changed the title Fix: Transcript Update (fixes: issue/35) Update: Transcript Update (fixes: issue/35) Aug 29, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Sep 2, 2024
View reviewed changes
Copy link

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks. Tested on Mac Safari with voiceOver, FF and Chrome.

@oliverfoster oliverfoster merged commit 87d4d50 into master Sep 12, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/35 branch September 12, 2024 11:16
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
@semantic-release-bot
Chore(release): 3.3.0 [skip ci]
724d4e7 
# [3.3.0](v3.2.3...v3.3.0) (2024-09-12)

### Update

* Transcript Update (fixes: issue/35) (#36) ([87d4d50](87d4d50)), closes [#36](#36)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@guywillis guywillis mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@lemmyadams lemmyadams lemmyadams approved these changes

Assignees

@joe-replin joe-replin

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip to transcript button not working
5 participants
@joe-replin @kirsty-hames @cahirodoherty-learningpool @lemmyadams @oliverfoster