Only set .drawer__item-title margin if followed by .drawer__item-body #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 9.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of applying
margin-bottomto.drawer__item-titledirectly, applymargin-topto.drawer__item-bodywhen needed.Most Drawer plugin items only include a title. It's a minor issue but the addition of margin makes the title display off-center vertically.
Fixes #486
Test PR
In your course, go to PageLevelProgress and inspect
.drawer__item-title. No margin should be applied. Same goes for Glossary or LanguagePicker.Go to Drawer Resources and inspect
.drawer__item-title. Margin should be applied to the top of.drawer__item-body, creating space between title and body.