Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added is-highlighted class #187

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix: Added is-highlighted class #187

merged 2 commits into from
Feb 4, 2025

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jan 16, 2025 •
edited
Loading

part of adaptlearning/adapt-contrib-mcq#229

Fix

  • Added is-highlighted class
  • Changed to mcq onKeyDown from deprecated onKeyPress

@oliverfoster oliverfoster self-assigned this Jan 16, 2025
swashbuck
swashbuck approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 22, 2025
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks 👍 Tested with Mac and iPhone

@oliverfoster oliverfoster merged commit 3aa2d75 into master Feb 4, 2025
@oliverfoster oliverfoster deleted the issue/229-voiceover-accessibility branch February 4, 2025 14:49
github-actions bot pushed a commit that referenced this pull request Feb 4, 2025
@semantic-release-bot
Chore(release): 7.6.4 [skip ci]
04e7134 
## [7.6.4](v7.6.3...v7.6.4) (2025-02-04)

### Fix

* Added is-highlighted class (#187) ([3aa2d75](3aa2d75)), closes [#187](#187)
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

🎉 This PR is included in version 7.6.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
accessibility bug released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @swashbuck @kirsty-hames @cahirodoherty-learningpool