Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Drawer close animation. Drawer and notify open focus #621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 3, 2025

Additional fixes to pr #601

fixes #619
fixes #620

Fix

@oliverfoster oliverfoster self-assigned this Feb 3, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks 👍 Tested FF, Chrome, Safari and iPhone. Screen reader tested with voiceOver on Mac Safari.

I don't have access to JAWS to test issue #620 but can confirm #619 fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Reviewing
Development

Successfully merging this pull request may close these issues.

Drawer / Notify - Links in <dialog> Drawer closes prematurely when activating controls inside it by keyboard
3 participants