Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Popup support in a11y disabled (fixes #616) #617

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix: Popup support in a11y disabled (fixes #616) #617

merged 1 commit into from
Jan 27, 2025

Conversation

oliverfoster
Copy link
Member

fixes #616

Fix

  • Enable popup support when config.json:_accessibility._isEnabled: false

@oliverfoster oliverfoster self-assigned this Jan 16, 2025
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster mentioned this pull request Jan 20, 2025
Closed
swashbuck
swashbuck approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 9404558 into master Jan 27, 2025
1 check passed
@oliverfoster oliverfoster deleted the issue/616 branch January 27, 2025 21:55
github-actions bot pushed a commit that referenced this pull request Jan 27, 2025
@semantic-release-bot
Chore(release): 6.60.4
2f7f5a7 
## [6.60.4](v6.60.3...v6.60.4) (2025-01-27)

### Fix

* Popup support in a11y disabled (fixes #616) (#617) ([9404558](9404558)), closes [#616](#616) [#617](#617)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.60.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@chris-steele chris-steele chris-steele approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug high priority released
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If accessibility is disabled dialogs cannot be opened
4 participants
@oliverfoster @swashbuck @chris-steele @cahirodoherty-learningpool