Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow tooltips to follow animations #583

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix: Allow tooltips to follow animations #583

merged 1 commit into from
Sep 30, 2024

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Sep 16, 2024 •
edited
Loading

fixes adaptlearning/adapt-contrib-hotgraphic#319

When animating the parent of a tooltip, the tooltip will follow the parent element.

Fix

  • Introduce animation loop for tooltip movement, triggered on onscreen animationStart, contentObjectView:ready and device:resize

Testing

  • Add an onscreen animation to the hotgraphic's block and scroll it into view

@oliverfoster oliverfoster self-assigned this Sep 16, 2024
@swashbuck

This comment was marked as outdated.

Sign in to view
swashbuck
swashbuck approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kirsty-hames
kirsty-hames approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment issue fixed testing in Chrome, Safari and FF on Mac.

Note, when onscreen animations are used, component (e.g. Hotgraphic) tooltips are visible before the component/block is visible and begins to transition in. As the tooltips sit outside of the block/component they don't receive the on screen styles applied to the targeted block/component.

@oliverfoster
Copy link
Member Author

Alignment issue fixed testing in Chrome, Safari and FF on Mac.

Note, when onscreen animations are used, component (e.g. Hotgraphic) tooltips are visible before the component/block is visible and begins to transition in. As the tooltips sit outside of the block/component they don't receive the on screen styles applied to the targeted block/component.

I'm happy for this to be a known issue.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@oliverfoster oliverfoster merged commit 5e08cfa into master Sep 30, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/319-hotgraphic branch September 30, 2024 14:02
github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
@semantic-release-bot
Chore(release): 6.53.10
5811933 
## [6.53.10](v6.53.9...v6.53.10) (2024-09-30)

### Fix

* Allow tooltips to follow animations (#583) ([5e08cfa](5e08cfa)), closes [#583](#583)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.53.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static tooltip positions are occasionally misaligned
4 participants
@oliverfoster @swashbuck @kirsty-hames @cahirodoherty-learningpool