New: Migration Scripts (fixes #57) #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| describe('adapt-contrib-blank - v2.0.0 > v4.1.3', async () => { | ||
| let blanks; | ||
|
|
||
| whereFromPlugin('adapt-contrib-blank - from v2.0.0', { name: 'adapt-contrib-blank', version: '<=4.1.3' }); |
There was a problem hiding this comment.
We only need to check if it's lower than the version we're updating to not equal to. Either '<4.1.3' or '<= 4.1.2'.
Suggested change
| whereFromPlugin('adapt-contrib-blank - from v2.0.0', { name: 'adapt-contrib-blank', version: '<=4.1.3' }); | |
| whereFromPlugin('adapt-contrib-blank - from v2.0.0', { name: 'adapt-contrib-blank', version: '<4.1.3' }); |
|
|
||
| whereContent('adapt-contrib-blank - where blank', async content => { | ||
| blanks = content.filter(({ _component }) => _component === 'blank'); | ||
| if (blanks) return true; |
There was a problem hiding this comment.
As per Ollie's suggestion (adaptlearning/adapt-contrib-accordion#159 (comment)) to condense these checks slightly suggested tweek
Suggested change
| if (blanks) return true; | |
| return blanks.length |
| return true; | ||
| }); | ||
|
|
||
| updatePlugin('adapt-contrib-blank - update to v4.1.3', { name: 'adapt-contrib-blank', version: '4.1.3', framework: '>=4' }); |
There was a problem hiding this comment.
Suggested change
| updatePlugin('adapt-contrib-blank - update to v4.1.3', { name: 'adapt-contrib-blank', version: '4.1.3', framework: '>=4' }); | |
| updatePlugin('adapt-contrib-blank - update to v4.1.3', { name: 'adapt-contrib-blank', version: '4.1.3', framework: '>=5.19.1' }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Testing
Test using this branch of the Adapt Framework which includes the scripts that handle the migration.
adaptlearning/adapt_framework#3633