Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GenerationMixin warning for AdapterModel classes #787

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Fix GenerationMixin warning for AdapterModel classes #787

merged 1 commit into from
Jan 27, 2025

Conversation

calpt
Copy link
Member

@calpt calpt commented Jan 26, 2025

Fixes the following warning for all AdapterModels:

LlamaAdapterModel has generative capabilities, as `prepare_inputs_for_generation` is explicitly overwritten. However, it doesn't directly inherit from `GenerationMixin`. From 👉v4.50👈 onwards, `PreTrainedModel` will NOT inherit from `GenerationMixin`, and this model will lose the ability to call `generate` and other related functions.

@calpt calpt marked this pull request as ready for review January 26, 2025 20:38
@calpt calpt merged commit ea2b639 into adapter-hub:main Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoImhof TimoImhof Awaiting requested review from TimoImhof

@lenglaender lenglaender Awaiting requested review from lenglaender

@hSterz hSterz Awaiting requested review from hSterz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@calpt