Define exports to support native ES Modules and tree shaking, and discourage unsupported entry points #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment, test line type instead.
Documented delimiter option
setImmediate instead of nextTick for node >=0.10
FossPrime
changed the title
|
That's one way to solve it 😄 |
|
Hum, I didn't notice our monorepo migration closed this issue, and I can't re-open it. I am however working on it since last week on my spare time and will get it done at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major semver change.
Migration
require('csv/lib/sync')torequire('csv/sync')require('csv/lib')torequire('csv')No changes required in the following situations
require('csv')import csv from 'csv'import csv from 'csv'; const { parse } = csvNew options, with
"type": "module"packages and from mjs scripts:import { parse } from 'csv'import parse from 'csv/sync'Reproduction:
https://runkit.com/hesygolu/60cab0ebed19ef001a500480
Related issues:
#207
#264
#276
adaltas/node-csv-parse#320