Sunton 8048S050: Configure display frequency in settings.toml #9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
added a commit
that referenced
this pull request
Jan 2, 2025
Sunton 8048S050: Configure display frequency in settings.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in #9661 @sandzco appears to have purchased a variant of this board that requires a different display frequency. I don't have either the original or variant boards but I have put this firmware on the makerfabs 7" board, which seems to be a close cousin, and the firmware at least loads without boot looping.
This update will allow the default display frequency to be overridden through a settings.toml parameter.
If this PR is merged I'll submit a PR to circuipython-org updating the board description to include the new parameter as well.