Add remaining Web Platform Tests for url_search_params::sort #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@npaun can you rebase? |
npaun
force-pushed
the
npaun/urlsearchparams-wpt-tests
branch
from
2a0fb1d to
e1d7107
Compare
|
@anonrig Done |
|
It seems macOS Bazel build is failing due to |
|
@anonrig I don't know why I triggered it because this isn't the only use of the variable name |
npaun
force-pushed
the
npaun/urlsearchparams-wpt-tests
branch
from
e1d7107 to
6b7aa9c
Compare
lemire
approved these changes
Jan 31, 2025
anonrig
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the remaining test cases for url_search_params::sort taken from WPT (https://github.com/web-platform-tests/wpt/blob/master/url/urlsearchparams-sort.any.js). They're all passing.
I skipped the case involving "ffi&🌈" because it's in @lemire's fix PR #863.