Add option to make a transfer from two selected transactions

[twk3]

Summary

Add an option in the selected transactions menu in mutli-account budget pages (all accounts, for budget/etc), that allows you to relate two transactions across accounts as a transfer.

Feature

Feature: #1891

Details

• Transactions amount must match
• Transactions must be from different acounts
• Split transactions not eligible

Workflows

Single account pages don't show the option at all in the selection menu:

Multi account pages always show the option in the selection menu, but disabled when the selections are not valid for the transfer action:

For valid selections the action is enabled in the selection tooltip:

Final PR Tasks

• extract the can-be-transfer logic to transfers.ts and reuse in both places
• Add tests
• Docs PR: Add docs on ability to create transfer from two existing transactions docs#321

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	6a3f3ad
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/65dd2bc7339d0900083caa65
😎 Deploy Preview	https://deploy-preview-2398.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	4.46 MB → 4.46 MB (+2.6 kB)	+0.06%

Changeset

File	Δ	Size
home/runner/work/actual/actual/packages/loot-core/src/client/transfer.ts	🆕 +457 B	0 B → 457 B
src/components/transactions/SelectedTransactions.jsx	📈 +766 B (+15.62%)	4.79 kB → 5.54 kB
src/components/accounts/Account.jsx	📈 +1.2 kB (+2.97%)	40.41 kB → 41.6 kB
src/components/accounts/Header.jsx	📈 +117 B (+0.83%)	13.72 kB → 13.84 kB
src/components/table.tsx	📈 +97 B (+0.40%)	23.9 kB → 24 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/wide.js	267.47 kB → 269.97 kB (+2.51 kB)	+0.94%
static/js/index.js	2.74 MB → 2.74 MB (+97 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/ButtonLink.js	379 B	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	79.85 kB	0%
static/js/BalanceTooltip.js	6.06 kB	0%
static/js/AppliedFilters.js	20.35 kB	0%
static/js/ReportRouter.js	1.2 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.2 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.2 MB	0%

[carkom]

You're my hero, I've wanted this function for ages. Thanks!

[yoyotogblo]

This is awesome... Thanks for this!

The next useful feature would be to match transactions. So if the transaction in one account is correctly to as a transfer, and the other isn't, you can go to the account with both transactions and match it up and it'd always use the transfer transaction for the match details (similar to how YNAB does it).