Skip to content

Commit

Permalink
Menu Option Disappears Completely On Certain Screen Size (#3880)
Browse files Browse the repository at this point in the history
* remove use of View component

* created a release note

* rename release note to PR number not issue number

* revert changes to check e2e tests

* redo changes

* indentify exact styling issue

* use style instead of css
  • Loading branch information
ericji1326 authored Dec 8, 2024
1 parent fa8ff79 commit e4b40fb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/desktop-client/src/components/accounts/Header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function AccountHeader({
onMakeAsNonSplitTransactions={onMakeAsNonSplitTransactions}
/>
)}
<View>
<View style={{ flex: '0 0 auto' }}>
{account && (
<>
<Button
Expand Down Expand Up @@ -427,7 +427,7 @@ export function AccountHeader({
</View>
</Button>
{account ? (
<View>
<View style={{ flex: '0 0 auto' }}>
<MenuButton
aria-label="Account menu"
ref={triggerRef}
Expand Down Expand Up @@ -456,7 +456,7 @@ export function AccountHeader({
</Popover>
</View>
) : (
<View>
<View style={{ flex: '0 0 auto' }}>
<MenuButton
aria-label="Account menu"
ref={triggerRef}
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/3880.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [ericji1326]
---

Fix bug where menu option icon disappearing completely on certain screen sizes.

0 comments on commit e4b40fb

Please sign in to comment.