Fix typecheck error

packages/desktop-client/e2e/budget.mobile.test.ts

@@ -60,6 +60,9 @@ async function setBudgetAverage(
     await budgetPage.goToPreviousMonth();
     const spentButton = await budgetPage.getButtonForSpent(categoryName);
     const spent = await spentButton.textContent();
+    if (!spent) {
+      throw new Error('Failed to get spent amount');
+    }
     totalSpent += currencyToAmount(spent) ?? 0;
   }
 
@@ -76,7 +79,7 @@ async function setBudgetAverage(
   return averageSpent;
 }
 
-const budgetTypes = ['Envelope', 'Tracking'];
+const budgetTypes = ['Envelope', 'Tracking'] as const;
 
 budgetTypes.forEach(budgetType => {
   test.describe(`Mobile Budget [${budgetType}]`, () => {
@@ -280,6 +283,10 @@ budgetTypes.forEach(budgetType => {
 
       const lastMonthBudget = await budgetedButton.textContent();
 
+      if (!lastMonthBudget) {
+        throw new Error('Failed to get last month budget');
+      }
+
       await budgetPage.goToNextMonth();
 
       await copyLastMonthBudget(budgetPage, categoryName);

packages/desktop-client/e2e/page-models/account-page.ts

@@ -56,8 +56,8 @@ export class AccountPage {
     this.selectTooltip = this.page.getByTestId('transactions-select-tooltip');
   }
 
-  async waitFor() {
-    await this.transactionTable.waitFor();
+  async waitFor(...options: Parameters<Locator['waitFor']>) {
+    await this.transactionTable.waitFor(...options);
   }
 
   /**

packages/desktop-client/e2e/page-models/mobile-account-page.ts

@@ -26,8 +26,8 @@ export class MobileAccountPage {
     });
   }
 
-  async waitFor() {
-    await this.transactionList.waitFor();
+  async waitFor(...options: Parameters<Locator['waitFor']>) {
+    await this.transactionList.waitFor(...options);
   }
 
   /**

packages/desktop-client/e2e/page-models/mobile-accounts-page.ts

@@ -14,14 +14,14 @@ export class MobileAccountsPage {
     this.accountListItems = this.accountList.getByTestId('account-list-item');
   }
 
-  async waitFor() {
-    await this.accountList.waitFor();
+  async waitFor(...options: Parameters<Locator['waitFor']>) {
+    await this.accountList.waitFor(...options);
   }
 
   /**
    * Get the name and balance of the nth account
    */
-  async getNthAccount(idx) {
+  async getNthAccount(idx: number) {
     const accountRow = this.accountListItems.nth(idx);
 
     return {
@@ -33,7 +33,7 @@ export class MobileAccountsPage {
   /**
    * Click on the n-th account to open it up
    */
-  async openNthAccount(idx) {
+  async openNthAccount(idx: number) {
     await this.accountListItems.nth(idx).click();
 
     return new MobileAccountPage(this.page);

packages/desktop-client/e2e/page-models/mobile-budget-menu-modal.ts

@@ -38,8 +38,8 @@ export class BudgetMenuModal {
     await this.heading.getByRole('button', { name: 'Close' }).click();
   }
 
-  async setBudgetAmount(newAmount) {
-    await this.budgetAmountInput.fill(String(newAmount));
+  async setBudgetAmount(newAmount: string) {
+    await this.budgetAmountInput.fill(newAmount);
     await this.budgetAmountInput.blur();
     await this.close();
   }

packages/desktop-client/e2e/page-models/mobile-budget-page.ts

@@ -102,8 +102,8 @@ export class MobileBudgetPage {
       : 'Tracking';
   }
 
-  async waitFor(options) {
-    await this.budgetTable.waitFor(options);
+  async waitFor(...options: Parameters<Locator['waitFor']>) {
+    await this.budgetTable.waitFor(...options);
   }
 
   async toggleVisibleColumns({
@@ -319,6 +319,9 @@ export class MobileBudgetPage {
 
   async openEnvelopeBudgetSummary() {
     const budgetSummaryButton = await this.#getButtonForEnvelopeBudgetSummary();
+    if (!budgetSummaryButton) {
+      throw new Error('Envelope budget summary button not found.');
+    }
     await budgetSummaryButton.click();
 
     return new EnvelopeBudgetSummaryModal(this.page.getByRole('dialog'));
@@ -350,6 +353,9 @@ export class MobileBudgetPage {
 
   async openTrackingBudgetSummary() {
     const budgetSummaryButton = await this.#getButtonForTrackingBudgetSummary();
+    if (!budgetSummaryButton) {
+      throw new Error('Tracking budget summary button not found.');
+    }
     await budgetSummaryButton.click();
 
     return new TrackingBudgetSummaryModal(this.page.getByRole('dialog'));

packages/desktop-client/e2e/page-models/mobile-edit-notes-modal.ts

@@ -20,7 +20,7 @@ export class EditNotesModal {
     await this.heading.getByRole('button', { name: 'Close' }).click();
   }
 
-  async updateNotes(notes) {
+  async updateNotes(notes: string) {
     await this.textArea.fill(notes);
     await this.saveNotesButton.click();
   }

packages/desktop-client/e2e/page-models/mobile-navigation.ts

@@ -7,6 +7,22 @@ import { MobileReportsPage } from './mobile-reports-page';
 import { MobileTransactionEntryPage } from './mobile-transaction-entry-page';
 import { SettingsPage } from './settings-page';
 
+const NAVBAR_ROWS = 3;
+const NAV_LINKS_HIDDEN_BY_DEFAULT = [
+  'Reports',
+  'Schedules',
+  'Payees',
+  'Rules',
+  'Settings',
+];
+const ROUTES_BY_PAGE = {
+  Budget: '/budget',
+  Accounts: '/accounts',
+  Transactions: '/transactions/new',
+  Reports: '/reports',
+  Settings: '/settings',
+};
+
 export class MobileNavigation {
   readonly page: Page;
   readonly heading: Locator;
@@ -22,31 +38,23 @@ export class MobileNavigation {
     this.navbarSelector = '[role=navigation]';
   }
 
-  static #NAVBAR_ROWS = 3;
-  static #NAV_LINKS_HIDDEN_BY_DEFAULT = [
-    'Reports',
-    'Schedules',
-    'Payees',
-    'Rules',
-    'Settings',
-  ];
-  static #ROUTES_BY_PAGE = {
-    Budget: '/budget',
-    Accounts: '/accounts',
-    Transactions: '/transactions/new',
-    Reports: '/reports',
-    Settings: '/settings',
-  };
-
   async dragNavbarUp() {
     const mainContentBoundingBox = await this.page
       .locator(this.mainContentSelector)
       .boundingBox();
 
+    if (!mainContentBoundingBox) {
+      throw new Error('Unable to get bounding box of main content.');
+    }
+
     const navbarBoundingBox = await this.page
       .locator(this.navbarSelector)
       .boundingBox();
 
+    if (!navbarBoundingBox) {
+      throw new Error('Unable to get bounding box of navbar.');
+    }
+
     await this.page.dragAndDrop(this.navbarSelector, this.mainContentSelector, {
       sourcePosition: { x: 1, y: 0 },
       targetPosition: {
@@ -61,39 +69,47 @@ export class MobileNavigation {
       .locator(this.navbarSelector)
       .boundingBox();
 
+    if (!boundingBox) {
+      throw new Error('Unable to get bounding box of navbar.');
+    }
+
     await this.page.dragAndDrop(this.navbarSelector, this.navbarSelector, {
       sourcePosition: { x: 1, y: 0 },
       targetPosition: {
         x: 1,
         // Only scroll until bottom of screen i.e. bottom of first navbar row.
-        y: boundingBox.height / MobileNavigation.#NAVBAR_ROWS,
+        y: boundingBox.height / NAVBAR_ROWS,
       },
     });
   }
 
-  async hasNavbarState(...states) {
+  async hasNavbarState(...states: string[]) {
     if ((await this.navbar.count()) === 0) {
       // No navbar on page.
       return false;
     }
 
     const dataNavbarState = await this.navbar.getAttribute('data-navbar-state');
+    if (!dataNavbarState) {
+      throw new Error('Navbar does not have data-navbar-state attribute.');
+    }
     return states.includes(dataNavbarState);
   }
 
-  async navigateToPage(pageName, pageModelFactory) {
+  async navigateToPage<T extends { waitFor: Locator['waitFor'] }>(
+    pageName: keyof typeof ROUTES_BY_PAGE,
+    pageModelFactory: () => T,
+  ): Promise<T> {
     const pageInstance = pageModelFactory();
 
-    if (this.page.url().endsWith(MobileNavigation.#ROUTES_BY_PAGE[pageName])) {
+    if (this.page.url().endsWith(ROUTES_BY_PAGE[pageName])) {
       // Already on the page.
       return pageInstance;
     }
 
     await this.navbar.waitFor();
 
-    const navbarStates = MobileNavigation.#NAV_LINKS_HIDDEN_BY_DEFAULT.includes(
-      pageName,
-    )
+    const navbarStates = NAV_LINKS_HIDDEN_BY_DEFAULT.includes(pageName)
       ? ['default', 'hidden']
       : ['hidden'];
 
@@ -136,7 +152,7 @@ export class MobileNavigation {
 
   async goToTransactionEntryPage() {
     return await this.navigateToPage(
-      'Transaction',
+      'Transactions',
       () => new MobileTransactionEntryPage(this.page),
     );
   }

packages/desktop-client/e2e/page-models/mobile-reports-page.ts

@@ -10,7 +10,7 @@ export class MobileReportsPage {
     this.overview = page.getByTestId('reports-overview');
   }
 
-  async waitFor(options) {
-    await this.overview.waitFor(options);
+  async waitFor(...options: Parameters<Locator['waitFor']>) {
+    await this.overview.waitFor(...options);
   }
 }

packages/desktop-client/e2e/page-models/mobile-transaction-entry-page.ts

@@ -6,7 +6,6 @@ export class MobileTransactionEntryPage {
   readonly page: Page;
   readonly header: Locator;
   readonly amountField: Locator;
-  readonly add: Locator;
   readonly transactionForm: Locator;
   readonly footer: Locator;
   readonly addTransactionButton: Locator;
@@ -22,8 +21,8 @@ export class MobileTransactionEntryPage {
     });
   }
 
-  async waitFor(options) {
-    await this.transactionForm.waitFor(options);
+  async waitFor(...options: Parameters<Locator['waitFor']>) {
+    await this.transactionForm.waitFor(...options);
   }
 
   async fillField(fieldLocator: Locator, content: string) {

packages/desktop-client/e2e/page-models/settings-page.ts

@@ -24,24 +24,24 @@ export class SettingsPage {
     );
   }
 
-  async waitFor(options) {
-    await this.settings.waitFor(options);
+  async waitFor(...options: Parameters<Locator['waitFor']>) {
+    await this.settings.waitFor(...options);
   }
 
   async exportData() {
     await this.exportDataButton.click();
   }
 
-  async useBudgetType(budgetType) {
+  async useBudgetType(budgetType: 'Envelope' | 'Tracking') {
     await this.switchBudgetTypeButton.waitFor();
 
     const buttonText = await this.switchBudgetTypeButton.textContent();
-    if (buttonText.includes(budgetType.toLowerCase())) {
+    if (buttonText?.includes(budgetType.toLowerCase())) {
       await this.switchBudgetTypeButton.click();
     }
   }
 
-  async enableExperimentalFeature(featureName) {
+  async enableExperimentalFeature(featureName: string) {
     if (await this.advancedSettingsButton.isVisible()) {
       await this.advancedSettingsButton.click();
     }