#884 Add forget password route and link to auth pages #888
Conversation
…ability and extensibility
-reset-password -set-password
- Disabled(expected) when captcha check failed and show tooltip why disabled.
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -46,13 +62,16 @@ import { IconMap } from "~/types/icon-map"; | |||
|
|
|||
| const localePath = useLocalePath(); | |||
|
|
|||
| // TODO: Please change with result of captcha check and remove the comment. | |||
| const isForgotPasswordDisabled = false; | |||
There was a problem hiding this comment.
@andrewtavis I'm not familiar with captcha check, so I added a TODO and it would be nice if you can handle this for me.
|
Thanks for this, @ahmedy00! I'll get to this early next week as I'm away for the weekend. So great to be able to review a PR from you again 😊 |
| const isAllRulesValid = computed(() => { | ||
| return rules.value.every((rule) => rule.isValid); | ||
| }); | ||
| const { rules, isAllRulesValid, checkRules, isPasswordMatch } = |
There was a problem hiding this comment.
Great to have this extracted and reusable, @ahmedy00! 😊
There was a problem hiding this comment.
Really perfect, @ahmedy00 - and as always 😊 Wonderful to have you back, and let's be in touch on if you'd like to work on something else sooner rather than later! Would also be happy to get on a call at some point if you'd like to discuss potential things to work on!
Contributor checklist
Description
This Pull Request contains new page definitions(reset-password, set-password). It also promises improvements to the userPasswordRules hook and more readable code in the auth layout.
Related issue