-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: insta and matrix #1072
feat: insta and matrix #1072
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Thanks for the PR and working towards closing all these out, @UnknownSean8! Answers to your questions:
What do you mean by a global field? Are you talking i18n here?
You're talking instead of I'll be checking this soon 😊 |
:native-behavior-options="nativeBehaviorOptions" | ||
:urlLink="getCurrentUrl()" | ||
:name="getCurrentName()" | ||
redirect-link="https://signal.me/#p" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is copied from the Signal entry and should be swapped over to something for Instagram, right?
Codewise all's looking good, @UnknownSean8 😊 Do you want to fix the Instagram link above and I'll then finalize the review? :) |
Quick check in here on the fix to the Instagram link, @UnknownSean8 :) No stress if you're busy atm! Let me know and I can also look into it 😊 |
Yup, all good, I'll fix it right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping at this, @UnknownSean8! 🚀 Really nice to have all of these rounded out finally 😊
Contributor checklist
Description
Instagram and Matrix share page.
Ideas:
Fix:
Thanks.
Related issue