Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insta and matrix #1072

Conversation

UnknownSean8
Copy link
Contributor

@UnknownSean8 UnknownSean8 commented Dec 28, 2024

Contributor checklist


Description

Instagram and Matrix share page.

Ideas:

  1. Maybe we can have a global field for social links?
  2. Social media name i18n could be global?

Fix:

  1. Instagram share is still copy and redirect type.

Thanks.

Related issue

Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit e1d1311
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6786ea28d650ce0008178bf9
😎 Deploy Preview https://deploy-preview-1072--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 28, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review December 28, 2024 21:57
@andrewtavis
Copy link
Member

Thanks for the PR and working towards closing all these out, @UnknownSean8! Answers to your questions:

  1. Maybe we can have a global field for social links?

What do you mean by a global field? Are you talking i18n here?

  1. Social media name i18n could be global?

You're talking instead of components.modal_share_page.signal we'd have a global key? Ultimately the keys are based on the files that they're used in :) We're looking into figuring out variably setting the keys in Vue files though!

I'll be checking this soon 😊

:native-behavior-options="nativeBehaviorOptions"
:urlLink="getCurrentUrl()"
:name="getCurrentName()"
redirect-link="https://signal.me/#p"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from the Signal entry and should be swapped over to something for Instagram, right?

@andrewtavis
Copy link
Member

Codewise all's looking good, @UnknownSean8 😊 Do you want to fix the Instagram link above and I'll then finalize the review? :)

@andrewtavis
Copy link
Member

Quick check in here on the fix to the Instagram link, @UnknownSean8 :) No stress if you're busy atm! Let me know and I can also look into it 😊

@UnknownSean8
Copy link
Contributor Author

Yup, all good, I'll fix it right now.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping at this, @UnknownSean8! 🚀 Really nice to have all of these rounded out finally 😊

@andrewtavis andrewtavis merged commit a24b3e8 into activist-org:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants