Skip to content

Commit

Permalink
Remove coverage settings to allow upload
Browse files Browse the repository at this point in the history
With these settings, simplecov returns a non-zero exit status which we don't want because it fails the test run step in the CI job and never gets to uploading the code coverage report for us to see what's wrong in the PR. For what its worth, I haven't run into this before with rspec so not sure if something could be different here with simplecov and rails test.
  • Loading branch information
javierjulio committed Jan 29, 2024
1 parent 01eb4b8 commit 7a959ce
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
require "simplecov-cobertura"
SimpleCov.start do
add_filter %r{^/test/}
minimum_coverage 98
maximum_coverage_drop 0.2
formatter SimpleCov::Formatter::CoberturaFormatter
end
end
Expand Down

0 comments on commit 7a959ce

Please sign in to comment.