CLI-1435: PHP error - undefined array key handled in pull command #1844
+40
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
============================================
- Coverage 92.92% 92.90% -0.02%
- Complexity 1846 1847 +1
============================================
Files 123 123
Lines 6964 6966 +2
============================================
+ Hits 6471 6472 +1
- Misses 493 494 +1 ☔ View full report in Codecov by Sentry. |
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1844/acli.phar |
danepowell
requested changes
Jan 21, 2025
| @@ -1517,6 +1517,10 @@ private function promptChooseAcsfSite(EnvironmentResponse $cloudEnvironment): mi | |||
| foreach ($acsfSites['sites'] as $domain => $acsfSite) { | |||
| $choices[] = "{$acsfSite['name']} ($domain)"; | |||
| } | |||
| if (!count($choices)) { | |||
| throw new AcquiaCliException("Could not get ACSF sites"); | |||
There was a problem hiding this comment.
You'll need to add a test case to cover this line. I'd suggest copying testRefreshAcsfFiles from PullFilesCommandTest.php and modify it to expect this exception. You'll need to modify mockGetAcsfSites() to return 0 sites to trigger the exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes CLI-1435
Proposed changes
Alternatives considered
Testing steps
./bin/acli ckc