-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors user data queries #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lermatroid
previously requested changes
Aug 25, 2024
For future reference and reviewer sanity, it might be nice to point this PR to the sister PR #77 and then point it back to dev afterwards just so we don't have to go through a lot of the same files bc 58 files is a lot. |
christianhelp
dismissed
Lermatroid’s stale review
September 10, 2024 19:12
Issues have been resolved.
christianhelp
previously approved these changes
Sep 10, 2024
christianhelp
previously approved these changes
Sep 11, 2024
christianhelp
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replaces heavily duplicated user data queries with functions that return new standard user interface types.
Closes #96
Depends on #77
Reviewers:
Review Guide:
db/types.ts:
Should interfaces other than Hacker include their relations?
Should redundant fields be removed from interfaces with relations?
Clerk exports a User interface as well; is this an issue?
db/functions/:
Changelog:
Adds db/types.ts to house database-specific types
Adds db/functions folder to house common queries and reduce code duplication
Replaces raw queries with functions where possible