Fix Registration Form and Uploads #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Very small changes and tested locally and on deployment. Bypassing required approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The blob upload currently puts all of the hackathon uploads into one, top-level, unorganized folder. This can be highly improved upon. While working to make this change, an unavoidable blocker occurred from our UI library that had to be fixed.
Before this PR, upgrading our UI library, shadCn, came with required updates to part of the registration form's Command Input. With upgrades to cmdk which is a library Shad uses for the Command components, it required the CommandGroup to be wrapped in a CommandList component.
What
/hackathon_name/resume/name_of_uploadSatisfies
HK-145 (#82)
HK-146 (#83)