Home Page Text & Formatting #50
Open
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Noticed that core value buttons were on another issue, will be removed soon! |
|
|
|
|
qhgill
previously requested changes
Jan 28, 2025
There was a problem hiding this comment.
This is a good start, great job using the concepts we discussed in meetings, it looks like you're understanding what we're teaching :). Make sure you're referencing the figma for important design features(I know we say the figma isn't your gospel but it is still the design we're going for in terms of general spacing, colors, etc.) so your component should be a bit larger, centered, and have the proper colors.
|
|
|
Not sure why the format is messed up, I ran npm format before pushing..? |
|
Changed background text, this was mainly an empty commit because my tests failed last PR. |
AndresAtUCR
commented
Jan 30, 2025
|
|
AndresAtUCR
dismissed
qhgill’s stale review
Requested changes have been made.
qhgill
requested changes
Feb 1, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Values subheading and text have been added.