Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the footer #55

Merged
merged 18 commits into from
Feb 5, 2025
+51 −5
Merged

Made the footer #55

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cb47993
Made the footer
daniyalbhat34 Feb 4, 2025
04270b4
Merge cb4799329b864b6d2f295c9271152f322b63c026 into 146d22a3642ced318…
daniyalbhat34 Feb 4, 2025
6897e60
convert images to webp
Feb 4, 2025
1447639
Fixed a mistake
daniyalbhat34 Feb 4, 2025
7c79ae8
Merge 14476399a64660a7a024ad92ffc3f5384ff913ac into 146d22a3642ced318…
daniyalbhat34 Feb 4, 2025
4c72ac6
convert images to webp
Feb 4, 2025
fedf101
Merge pull request #57 from acm-ucr/acm-ucr/images_dcf8bb89180a2376
fardinzam Feb 4, 2025
4c8dd19
Merge pull request #56 from acm-ucr/acm-ucr/images_0bccbeef280ab204
fardinzam Feb 4, 2025
fb2c4bf
Merge branch 'dev' of https://github.com/acm-ucr/hsa-website into dan…
daniyalbhat34 Feb 4, 2025
59703ca
Added the svg image and logos
daniyalbhat34 Feb 4, 2025
e66a0fb
Added svg image and the logos
daniyalbhat34 Feb 4, 2025
61a4134
Merge branch 'daniyal/footer' of https://github.com/acm-ucr/hsa-websi…
daniyalbhat34 Feb 4, 2025
c9e1cb4
fixed build error
daniyalbhat34 Feb 4, 2025
030b620
Another try
daniyalbhat34 Feb 4, 2025
a522b05
Merge branch 'dev' of https://github.com/acm-ucr/hsa-website into dan…
daniyalbhat34 Feb 4, 2025
2f7342d
New changes
daniyalbhat34 Feb 4, 2025
9eca674
Image error
daniyalbhat34 Feb 4, 2025
72455d0
Fixing the error
daniyalbhat34 Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added public/assets/Facebook.webp
View file
Open in desktop
Binary file not shown.
Binary file added public/assets/Linktree.webp
View file
Open in desktop
Binary file not shown.
Binary file added public/assets/contact.webp
View file
Open in desktop
Binary file not shown.
Binary file added public/assets/image2.webp
View file
Open in desktop
Binary file not shown.
Binary file added public/assets/insta.webp
View file
Open in desktop
Binary file not shown.
34 changes: 31 additions & 3 deletions src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,39 @@
import Border from "./Border";
import Image from "next/image";
import Facebook from "@/public/assets/Facebook.webp";
import Instagram from "@/public/assets/insta.webp";
import Image2 from "@/public/assets/image2.webp";
import Linktree from "@/public/assets/Linktree.webp";
import Contact from "@/public/assets/contact.webp";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless you're importing pictures, assets should be exported from Figma as SVG. But you shouldn't export the logos, get Instagram and Facebook from Lucide. For the Linktree logo use this link:
https://brandfetch.com/linktr.ee?view=library&library=default&collection=logos

import Link from "next/link";

const Footer = () => {
return (
<>
<div>
<Border />
<div className="bg-hsa-gray-200">Footer</div>
</>
<div className="bg-hsa-gray-200 pb-6 pt-6">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pb-6 pt-6 --> py-6

<div className="sm:px-15 flex flex-row justify-between px-8">
Copy link
Contributor

@fardinzam fardinzam Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add flex-row, it's the default when declaring flex. make sure to remove the other flex-rows too

<div className="flex flex-row justify-start">
<Image src={Image2} alt="Image2" className="w-10 sm:w-14" />
</div>
<div className="flex w-[50%] flex-row justify-end gap-3 pb-1 pt-2">
<Image src={Contact} alt="Contact" className="pb-1" />
<Link href="https://www.instagram.com/hsa.ucr/" target="_blank">
<Image src={Instagram} alt="Instagram" className="pt-1" />
</Link>
<Link
href="https://www.facebook.com/hsa.ucriverside"
target="_blank"
>
<Image src={Facebook} alt="Facebook" />
</Link>
<Link href="linktr.ee/hsaucr" target="_blank">
<Image src={Linktree} alt="Facebook" />
</Link>
</div>
</div>
</div>
</div>
);
};

Expand Down
Loading