Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added News component #18

Merged
merged 2 commits into from
Jan 28, 2025
Merged

added News component #18

merged 2 commits into from
Jan 28, 2025

Conversation

stricker1
Copy link
Collaborator

image

@stricker1 stricker1 self-assigned this Jan 20, 2025
aldriebarcena
aldriebarcena requested changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@aldriebarcena aldriebarcena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure your pr is passing all the tests. You can use npm run build to simulate the tests run before you push your branch.

@stricker1
Copy link
Collaborator Author

fixed, added a News component itself into page.tsx

stormyy00
stormyy00 reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@stormyy00 stormyy00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the merge conflict then should be good

@stormyy00 stormyy00 merged commit 83f22a3 into dev Jan 28, 2025
5 checks passed
@stormyy00 stormyy00 deleted the stricker1/News branch January 28, 2025 01:34
@stricker1 stricker1 linked an issue Jan 28, 2025 that may be closed by this pull request
news component #6
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldriebarcena aldriebarcena aldriebarcena requested changes

@stormyy00 stormyy00 stormyy00 approved these changes

Assignees

@stricker1 stricker1

Labels
ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

news component
3 participants
@stricker1 @aldriebarcena @stormyy00