Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Improve code organisation #42

Closed
wants to merge 9 commits into from
Closed

Improve code organisation #42

wants to merge 9 commits into from

Conversation

eoinkelly
Copy link
Contributor

PR #41 will add a new kind of API adapter (for Contentful) and add more functionality to our Slack integration. In preparation for these changes, this PR re-organises the code.

@eoinkelly
Copy link
Contributor Author

eoinkelly commented Dec 26, 2023 •
edited
Loading

The leaveReminder.ts module has some modules which it (and only it) uses. I'm not sure what an idiomatic way to represent this in TS is so I picked:

src/leaveReminder.ts
src/leaveReminder/leaves.ts
src/leaveReminder/sortByUsers.ts

This is quite "railsy" so I'm assuming it can be made more idiomatic. Feedback welcome on this in particular.

@eoinkelly eoinkelly marked this pull request as ready for review December 26, 2023 20:23
@eoinkelly eoinkelly requested a review from G-Rath December 26, 2023 20:23
@eoinkelly eoinkelly mentioned this pull request Dec 26, 2023
Closed
@eoinkelly
Copy link
Contributor Author

This change is too specifically for Ackama

@eoinkelly eoinkelly closed this Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@G-Rath G-Rath Awaiting requested review from G-Rath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eoinkelly