-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file, file_parameter and scanner SQLAlchemy models #1207
Add file, file_parameter and scanner SQLAlchemy models #1207
Conversation
Just one quick question. I named the model for the |
@maximemulder there can be files in the files table that are not MRI. I would change to |
Ahok makes sense. Do you prefer just |
I think just |
Okay, I changed the name ! By the way I used |
Probably best to stick with |
Updated ! Once this is merged I will update the integration test PR to also ensure the files have been inserted in the database (hopefully Friday). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In order to improve the integration tests for
run_dicom_archive_loader.py
. I want to query thefiles
table to make sure the files are inserted in the database. This PR adds SQLAlchemy model definitions for this table (andparameter_file
andmri_scanner
because why not).The integration tests pass therefore the models are correct !