Integration test for run_dicom_archive_loader.py
#1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximemulder
added
the
Area: CI
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
5586936 to
857053b
Compare
maximemulder
changed the title
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
857053b to
b73ecff
Compare
maximemulder
changed the title
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
25 times, most recently
from
63dc912 to
25bd52d
Compare
|
There is now a test to check that a file has indeed been inserted in the database ! |
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
2 times, most recently
from
52ef719 to
632b453
Compare
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
632b453 to
e649bcd
Compare
|
Wait, this is not Samir's brain, someone lied to me !!!
|
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
7ea8ec7 to
c192ce4
Compare
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
50bc15a to
a0cd5f3
Compare
maximemulder
force-pushed
the
2024-10-18_integration-s3
branch
from
a0cd5f3 to
8bf736f
Compare
laemtl
approved these changes
Dec 17, 2024
maximemulder
added a commit
to maximemulder/Loris-MRI
that referenced
this pull request
Dec 17, 2024
add integration test put keys in github repo debugging add database check add comments and debugging remove s3 keys change converter in test check file tree fix doc fix docs 2 rename variable go back to using s3 keys fix path try fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mounts the S3 bucket in CI and adds an integration test for
run_dicom_archive_loader.py!