Apply suggestions from code review

Co-authored-by: Jouni Järvinen <[email protected]>
acemod · Feb 9, 2025 · af48379 · af48379
1 parent a07694b
commit af48379
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/addons/spike/functions/fnc_camera_cycleViewMode.sqf b/addons/spike/functions/fnc_camera_cycleViewMode.sqf
@@ -1,7 +1,7 @@
 #include "..\script_component.hpp"
 /*
  * Author: Dani (TCVM)
- * Cycles camera thermal mode (if avaliable)
+ * Cycles camera thermal mode (if available)
  *
  * Arguments:
  * 0: Camera <OBJECT>

diff --git a/addons/spike/functions/fnc_camera_init.sqf b/addons/spike/functions/fnc_camera_init.sqf
@@ -58,7 +58,7 @@ private _logic = "Logic" createVehicleLocal _pos;
 private _initPosX = (tan _initGimbalAngleX) * GIMBAL_LOGIC_OFFSET;
 private _initPosY = (tan _initGimbalAngleY) * GIMBAL_LOGIC_OFFSET;
 
-private _projectileBounds = (1 boundingBoxReal _projectile);
+private _projectileBounds = 1 boundingBoxReal _projectile;
 private _projectileSize = (_projectileBounds#1) vectorDiff (_projectileBounds#0);
 _activeCameraNamespace setVariable [QGVAR(projectileSize), _projectileSize#1];
 

diff --git a/addons/spike/functions/fnc_camera_switchTo.sqf b/addons/spike/functions/fnc_camera_switchTo.sqf
@@ -14,9 +14,9 @@
  *
  * Public: No
  */
-params ["_cameraNamespace"];
-
 if ([] call FUNC(camera_userInCamera)) exitWith {};
+
+params ["_cameraNamespace"];
 private _camera = _cameraNamespace getVariable QGVAR(camera);
 private _projectile = _cameraNamespace getVariable QGVAR(missile);
 _camera cameraEffect ["internal", "BACK"];

diff --git a/addons/spike/functions/fnc_camera_update.sqf b/addons/spike/functions/fnc_camera_update.sqf
@@ -94,7 +94,7 @@ if (_hasGimbal) then {
             _cameraNamespace setVariable [QGVAR(lastMovedGroundPos), _lastGroundPos];
         };
 
-        if (_trackLockedPosition && { (_seekerTargetPos isNotEqualTo [0, 0, 0]) } && _canStopDesignating) then {
+        if (_trackLockedPosition && _canStopDesignating && { _seekerTargetPos isNotEqualTo [0, 0, 0] }) then {
             _lastGroundPos = _seekerTargetPos;
         };
 

diff --git a/addons/spike/functions/fnc_camera_userInCamera.sqf b/addons/spike/functions/fnc_camera_userInCamera.sqf
@@ -14,8 +14,8 @@
  *
  * Public: No
  */
-params [["_cameraNamespace", objNull]];
-
 if (isNil QGVAR(activeCamera)) exitWith { false };
 
+params [["_cameraNamespace", objNull]];
+
 (!isNull GVAR(activeCamera)) && { isNull _cameraNamespace || (_cameraNamespace isEqualTo GVAR(activeCamera)) };