-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Analytics #32
base: master
Are you sure you want to change the base?
Conversation
There is a new session model but the model is not used. I think having a session view would be very useful. Will that be added? |
@@ -36,18 +40,44 @@ def rescue_steps(message) | |||
def record_activity | |||
activity_param = { | |||
activity_type: "#{params[:controller]}\##{params[:action]}", | |||
user_id: current_user.nil? ? nil : current_user[:id], | |||
user_id: current_user.nil? ? nil : current_user['id'].to_i, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we push the new updates to production, will the old data be a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly. I'll revert this change back.
I wasn't even aware that a session model was made. I don't see why this is even needed. A session view doesn't make much sense, since a session is only for users to log in and stay logged in with their session is active. Could you be more specific for what exactly you were looking for with a session view? |
I'm actually reverting this change |
I would like to group the activities into IPMs (each IPM is a session, in that case). So we can tell roughly when students have IPMs and how many stories are pointed in each IPM. |
@adnanhemani Can you fix the CI and merge this PR? I'll add the session stuff in a separate PR later. |
Allows us to see the analytics for each project.