CS61B_Graph_Traversal_Element #15
Conversation
There was a problem hiding this comment.
i don't understand where the is_sublist questions are coming from. what do they have to do with the graph traversal element?
names like New_1 and New_1_copy2 are profoundly uninformative. please name things according to what they actually are.
why are there questions BFS_Old_1 and BFS_Old_copy1 etc? remember, this is the repo that is going to be seen by the public. ie professors and students wanting to use the element to create course content. giving names like that to example questions or example assessments makes it impossible to tell what's what without looking into every file. put yourself in the position of someone who has never seen this element before and is trying to use this repo as a way of learning how to develop questions with it. what would you yourself want to see in that case?
please do a thorough cleaning to get rid of any files in the PR that are not directly reltaed to your work; to delete files that are obsolete or not intended to be used as current examples or documentation; and to name things with names that are much more descriptive.
let me know when i should look again, but what is here now is not acceptable for public presentation.
|
Updated naming of files and deleted irrelevant files. |
|
is this ready for re-review?
On Dec 18, 2023, at 15:58, dahluwalia ***@***.***> wrote:
Updated naming of files and deleted irrelevant files.
—
Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACCMTASUR47WEZVWMKZBL3YKDKCZAVCNFSM6AAAAABA2GPBZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRRHA3TOOJUGM>.
You are receiving this because you commented.
Armando Fox (he, él, il, lui)
Professor, Computer Science Division • Faculty Advisor for Digital Learning Strategy, CDSS & VPUE
CS Diversity Officer, College of Engineering Equity Council, Campus Equity Advisor
390 Soda Hall MC#1776, Berkeley, CA, 94720-1776 • +1.510.642.6820 / http://www.cs.berkeley.edu/~fox <http://www.cs.berkeley.edu/~fox> • PGP/GPG key ID: 0x9AD0E747
-----
|
There was a problem hiding this comment.
- please don't delete the global README.md file
- .DS_Store files are spurious and created by Mac OS, they should never be versioned
- why is the CS169A/original_questions directory under your project's directories?
- why did all the other projects' directories/questions now get moved under yours?
this is a mess. i think you need to start from a clean PR and add your files one at a time and with caution. i am not willing to mess up the main repo.
Packaged interactive graph element