crud operations #4
Conversation
| public interface TaxiTripsRepository extends JpaRepository<TaxiTripsModel, Long> { | ||
| @Query(value = "select tableData from TaxiTripsModel tableData where tableData.taxiID = :taxiID", | ||
| countQuery = "select count(tableData) from TaxiTripsModel tableData where tableData.taxiID = :taxiID") | ||
| Page<TaxiTripsModel> searchByTaxiID(@Param("taxiID") Long taxiID, Pageable pageable); |
There was a problem hiding this comment.
this is not a search, i believe we have getOne here : https://docs.spring.io/spring-data/jpa/docs/current/api/org/springframework/data/jpa/repository/JpaRepository.html#getOne-ID-
There was a problem hiding this comment.
@vanduc1102 I already have findById , i think it's similar to getOne ? Just i receiving Optional instead of null if row not found
This method just searching by other field, not included to JPA Repo
| @Autowired | ||
| private TaxiTripsService mTaxiTripsService; | ||
|
|
||
| @GetMapping(value = "all") |
There was a problem hiding this comment.
we dont need to add all or delete
in REST we have a convention to use HTTP verb
eg:
GET / to findAll
GET /{id} getOne
POST / to create an object
PUT / to update an object
DELETE /{id} to detele an object
please go through the article here : https://hackernoon.com/restful-api-designing-guidelines-the-best-practices-60e1d954e7c9
There was a problem hiding this comment.
please push your changes :)
|
|
||
| @RestController | ||
| @RequestMapping("/v1/taxitrips") | ||
| public class CrudAPIController { |
There was a problem hiding this comment.
should be TaxiTripController
| @@ -3,13 +3,11 @@ | |||
| import com.apac.test.apactakehometest.async.AsyncService; | |||
There was a problem hiding this comment.
we should move the implementation here into TaxiTripController
under a path
POST /import-csv
| @@ -0,0 +1,68 @@ | |||
| package com.apac.test.apactakehometest.controller; | |||
Added CRUD operations:
Moved all operations to separate Service