-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Fix Failing Users Property Based Tests #2134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Fix spelling mistake Signed-off-by: Rodney Osodo <[email protected]>
0fa337e
to
6fcac71
Compare
Signed-off-by: Rodney Osodo <[email protected]>
6fcac71
to
3dd96a9
Compare
dborovcanin
previously approved these changes
Apr 3, 2024
WashingtonKK
requested changes
Apr 3, 2024
Signed-off-by: Rodney Osodo <[email protected]>
WashingtonKK
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 4, 2024
Signed-off-by: Rodney Osodo <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 5, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: nyagamunene <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 7, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: nyagamunene <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: JeffMboya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rodney Osodo [email protected]
What type of PR is this?
This is a fix PR since it fixes failing schemathesis tests
What does this do?
Enforces error wrapping on users service to fix failing schemathesis tests
Which issue(s) does this PR fix/relate to?
No issue
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
No, documentation is not needed.
Notes