Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix Failing Users Property Based Tests #2134

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

rodneyosodo
Copy link
Member

Signed-off-by: Rodney Osodo [email protected]

What type of PR is this?

This is a fix PR since it fixes failing schemathesis tests

What does this do?

Enforces error wrapping on users service to fix failing schemathesis tests

Which issue(s) does this PR fix/relate to?

No issue

Have you included tests for your changes?

Yes, I have included tests for my changes.

Did you document any new/modified feature?

No, documentation is not needed.

Notes

@rodneyosodo rodneyosodo force-pushed the users-schemathesis branch 2 times, most recently from 0fa337e to 6fcac71 Compare April 3, 2024 10:22
Signed-off-by: Rodney Osodo <[email protected]>
dborovcanin
dborovcanin previously approved these changes Apr 3, 2024
api/openapi/users.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@WashingtonKK WashingtonKK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin merged commit eb6b201 into absmach:main Apr 3, 2024
6 checks passed
nyagamunene pushed a commit to nyagamunene/supermq that referenced this pull request Apr 4, 2024
nyagamunene pushed a commit to nyagamunene/supermq that referenced this pull request Apr 5, 2024
nyagamunene pushed a commit to nyagamunene/supermq that referenced this pull request Apr 7, 2024
JeffMboya pushed a commit to JeffMboya/supermq that referenced this pull request Apr 11, 2024
@rodneyosodo rodneyosodo deleted the users-schemathesis branch October 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants