NOISSUE - Add group tests to users and things service #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
force-pushed
the
NOISSUE_groups_tests
branch
from
a0f6477 to
fd4cb3a
Compare
felixgateru
force-pushed
the
NOISSUE_groups_tests
branch
from
fd4cb3a to
092f50e
Compare
rodneyosodo
requested changes
Apr 4, 2024
WashingtonKK
force-pushed
the
NOISSUE_groups_tests
branch
from
092f50e to
f525bb9
Compare
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
felixgateru
force-pushed
the
NOISSUE_groups_tests
branch
from
f525bb9 to
f77dee9
Compare
dborovcanin
requested changes
Apr 5, 2024
things/api/http/endpoints_test.go
Outdated
| err error | ||
| }{ | ||
| { | ||
| desc: "unassign users to group successfully", |
There was a problem hiding this comment.
unassign users from a group successfully
There was a problem hiding this comment.
Fux other cases, as well.
users/api/endpoint_test.go
Outdated
| err error | ||
| }{ | ||
| { | ||
| desc: "assign groups to group successfully", |
There was a problem hiding this comment.
assign group to a parent group successfully
There was a problem hiding this comment.
Use assign group to a parent group instead of assign group to a group.
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
approved these changes
Apr 5, 2024
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 7, 2024
Signed-off-by: 1998-felix <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 10, 2024
Signed-off-by: 1998-felix <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
Signed-off-by: 1998-felix <[email protected]> Signed-off-by: JeffMboya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature as it adds groups tests to users and things service using the groups service mocks.
What does this do?
This adds groups tests to users and things services.
Which issue(s) does this PR fix/relate to?
None.
Have you included tests for your changes?
No since this is the test file.
Did you document any new/modified feature?
Yes, documentation in in code comments.
Notes