MG-2060 - Remove int32 type in policy interface #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
force-pushed
the
MG-2060-RemoveInt32TypeInPolicyInterface
branch
from
43c4d0e to
d028325
Compare
rodneyosodo
requested changes
Apr 2, 2024
dborovcanin
force-pushed
the
MG-2060-RemoveInt32TypeInPolicyInterface
branch
from
3c823a9 to
76a6315
Compare
nyagamunene
force-pushed
the
MG-2060-RemoveInt32TypeInPolicyInterface
branch
from
76a6315 to
2c1fee9
Compare
rodneyosodo
requested changes
Apr 3, 2024
dborovcanin
force-pushed
the
MG-2060-RemoveInt32TypeInPolicyInterface
branch
from
25338e3 to
f9d1e36
Compare
nyagamunene
force-pushed
the
MG-2060-RemoveInt32TypeInPolicyInterface
branch
from
f9d1e36 to
b76ba4a
Compare
dborovcanin
force-pushed
the
MG-2060-RemoveInt32TypeInPolicyInterface
branch
from
3d823aa to
4f1fae0
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene
force-pushed
the
MG-2060-RemoveInt32TypeInPolicyInterface
branch
from
4f1fae0 to
df48909
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
arvindh123
approved these changes
Apr 3, 2024
dborovcanin
approved these changes
Apr 4, 2024
dborovcanin
changed the title
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 7, 2024
Signed-off-by: nyagamunene <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 10, 2024
Signed-off-by: nyagamunene <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 11, 2024
Signed-off-by: nyagamunene <[email protected]> Signed-off-by: JeffMboya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it changes the integer type of limit and count parameters in policyAgent and Authz interface .
What does this do?
It changes the the limit and count parameter in policyAgent and Authz interface from int32 to uint64.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes. I have include test for my changes.
Did you document any new/modified feature?
No.
Notes