MG-2069 - Remove relation requirement from entity unassignment #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindh123
reviewed
Apr 3, 2024
arvindh123
reviewed
Apr 3, 2024
WashingtonKK
force-pushed
the
MG-2069
branch
6 times, most recently
from
7d11d58 to
0bc0ebf
Compare
dborovcanin
requested changes
Apr 10, 2024
rodneyosodo
requested changes
Apr 11, 2024
WashingtonKK
force-pushed
the
MG-2069
branch
6 times, most recently
from
3ad6f7b to
bdfebc7
Compare
rodneyosodo
requested changes
Apr 18, 2024
WashingtonKK
force-pushed
the
MG-2069
branch
3 times, most recently
from
d3042c7 to
1b94b17
Compare
WashingtonKK
force-pushed
the
MG-2069
branch
2 times, most recently
from
672668d to
f374c4d
Compare
dborovcanin
requested changes
Apr 19, 2024
WashingtonKK
force-pushed
the
MG-2069
branch
2 times, most recently
from
bcd6de1 to
09bd9ba
Compare
rodneyosodo
previously approved these changes
Apr 23, 2024
Signed-off-by: WashingtonKK <[email protected]> Remove relation requirement from validate Signed-off-by: WashingtonKK <[email protected]> fix remove policies Signed-off-by: WashingtonKK <[email protected]> feat: remove policy check Signed-off-by: WashingtonKK <[email protected]> fix: ci Signed-off-by: WashingtonKK <[email protected]> fix: tests Signed-off-by: WashingtonKK <[email protected]> fix tests Signed-off-by: WashingtonKK <[email protected]> fix api docs Signed-off-by: WashingtonKK <[email protected]> fix: property based tests Signed-off-by: WashingtonKK <[email protected]> revert add policies Signed-off-by: WashingtonKK <[email protected]> Refactor relation check Signed-off-by: WashingtonKK <[email protected]> fix: ci Signed-off-by: WashingtonKK <[email protected]>
Signed-off-by: WashingtonKK <[email protected]>
Signed-off-by: WashingtonKK <[email protected]> enhance relation query Signed-off-by: WashingtonKK <[email protected]> refactor query Signed-off-by: WashingtonKK <[email protected]>
Signed-off-by: WashingtonKK <[email protected]>
Signed-off-by: WashingtonKK <[email protected]>
dborovcanin
requested changes
Apr 23, 2024
Signed-off-by: WashingtonKK <[email protected]>
Signed-off-by: WashingtonKK <[email protected]>
dborovcanin
approved these changes
Apr 23, 2024
arvindh123
reviewed
Apr 23, 2024
| AND object_id = :object_id | ||
| ` | ||
| if pc.Relation != "" { | ||
| q = fmt.Sprintf("%s AND relation = :relation", q) |
There was a problem hiding this comment.
@WashingtonKK There will be only one relation in the Domain.
So no need to consider relation here
There was a problem hiding this comment.
@WashingtonKK Please check this one and send a follow-up PR for it.
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
May 15, 2024
…ch#2130) Signed-off-by: WashingtonKK <[email protected]>
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
May 15, 2024
…ch#2130) Signed-off-by: WashingtonKK <[email protected]> Signed-off-by: JeffMboya <[email protected]>
andychao217
pushed a commit
to andychao217/magistrala
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it changes the following functionality: Unassign entity.
What does this do?
Removes the relation requirement from unassigning an entity. When the relation is provided, only the user with that relation is removed, when not provided - all relations are removed.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
No
Notes
Signed-off-by: WashingtonKK [email protected]