-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Fix links in README.md file #2129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasko
previously approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove GPL3-licenced test dependencies Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
349b714
to
c16530d
Compare
Signed-off-by: Dusan Borovcanin <[email protected]>
c16530d
to
50752d8
Compare
rodneyosodo
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also change:
- emails on api docs
smpp
readme atconsumers/notifiers/smpp/README.md
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
rodneyosodo
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 4, 2024
Signed-off-by: Dusan Borovcanin <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 5, 2024
Signed-off-by: Dusan Borovcanin <[email protected]> Signed-off-by: nyagamunene <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 7, 2024
Signed-off-by: Dusan Borovcanin <[email protected]> Signed-off-by: nyagamunene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a chore pull request addressing some links and updates in README.md and some other minor fixes.
What does this do?
This pull request updates links in README files and provides smaller updates in the root README file. It also updates some testing dependencies.
Which issue(s) does this PR fix/relate to?
There is no such issue.
Have you included tests for your changes?
N/A
Did you document any new/modified feature?
N/A
Notes
N/A