MF - 1758 - Sync With Benchmark Testing #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
changed the title
rodneyosodo
force-pushed
the
noissue-benchmark
branch
4 times, most recently
from
85f90e5 to
bbd56f8
Compare
SammyOina
approved these changes
Oct 18, 2023
rodneyosodo
force-pushed
the
noissue-benchmark
branch
6 times, most recently
from
f667c72 to
6909e73
Compare
rodneyosodo
force-pushed
the
noissue-benchmark
branch
from
55f52a8 to
036fff7
Compare
arvindh123
reviewed
Oct 24, 2023
docker/.env
Outdated
|
|
||
| ## Call home | ||
| MF_SEND_TELEMETRY=true | ||
|
|
||
| ## Postgres | ||
| MF_POSTGRES_MAX_CONNECTIONS=100000 |
There was a problem hiding this comment.
Why we should have 100,000 connections by default ?
There was a problem hiding this comment.
Reduced to 100 i.e default
arvindh123
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Expect POSTGRES_MAX_CONNECTIONS limit everything look good.
Some thing can we have like this below
In .env
-- MF_POSTGRES_MAX_CONNECTIONS=100In docker-compose.yaml
-- MF_POSTGRES_MAX_CONNECTIONS: ${MF_POSTGRES_MAX_CONNECTIONS}
++ MF_POSTGRES_MAX_CONNECTIONS: ${MF_POSTGRES_MAX_CONNECTIONS:-100}}
dborovcanin
approved these changes
Oct 24, 2023
This adds a new environment variable `MF_JAEGER_TRACE_RATIO` to the `docker/.env` file. The variable is used to set the ratio of requests traced. Additionally, this commit also adds a new environment variable `MF_POSTGRES_MAX_CONNECTIONS` for configuring the maximum number of connections for the Postgres database. These changes are made to enhance the configuration and scalability of the core services. Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
drasko
force-pushed
the
noissue-benchmark
branch
from
297d99a to
ce45014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
MF_JAEGER_TRACE_RATIOi.e. don't always trace every request. 1.0 means always sample while 0.0 means never sample. This has proven useful for benchmark testing as when the ratio is 1.0 the Jaeger container uses a lot of memoryMF_POSTGRES_MAX_CONNECTIONS. This is to increase the connected clients to Postgres i.e. previously a max of 100 clients was not ideal for testingWhich issue(s) does this PR fix/relate to?
Related to #1758
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
Linked with absmach/benchmark#10