Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorecard Integration #1294

Open
wants to merge 60 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
173db43
Add ScoreCard config into settings.py
404-geek Jun 26, 2024
272b99c
code style fix nexB#598
404-geek Jun 26, 2024
944cee2
Merge branch 'refs/heads/ossf_api_template' into scorecard_integration
404-geek Jun 26, 2024
bc445c1
settings.py code style fix nexB#598
404-geek Jun 26, 2024
f241b3b
mixin import and models declaration nexB#1283
404-geek Jun 27, 2024
605a5cf
transforming scorecard data into object for saving nexB#1283
404-geek Jun 27, 2024
3833dca
added test cases for saving scorecard data into models and modified s…
404-geek Jul 1, 2024
37380c8
Merge branch 'main' into feat-models_integration
404-geek Jul 1, 2024
5502b5f
added score checks mixin to models nexB#1283
404-geek Jul 1, 2024
2aeb2a4
Merge branch 'nexB:main' into feat-models_integration
404-geek Jul 3, 2024
103fca0
empty details in score response handled nexB#1283
404-geek Jul 3, 2024
952e6a6
changed class names to camel case for models and modified the tests n…
404-geek Jul 3, 2024
3ba3db5
code formatted nexB#1283
404-geek Jul 3, 2024
2f2b846
code formatted nexB#1283
404-geek Jul 3, 2024
39a056d
code formatted nexB#1283
404-geek Jul 3, 2024
e5f3e7a
docstrings formatted nexB#1283
404-geek Jul 3, 2024
c2f5c4d
created basic fetch and availability functions for scorecode pipeline…
404-geek Jul 4, 2024
6ee5b07
Merge branch 'nexB:main' into scorecard_integration
404-geek Jul 7, 2024
760afc2
Merge remote-tracking branch 'origin/scorecard_integration' into scor…
404-geek Jul 7, 2024
0dbc92f
modified doc strings and models and imported ScoreCode package in set…
404-geek Jul 7, 2024
d652f42
setup.cfg nexB#1283
404-geek Jul 7, 2024
aa154c0
Merge branch 'nexB:main' into scorecard_integration
404-geek Jul 8, 2024
37ad73a
Merge branch 'refs/heads/feat-models_integration' into scorecard_inte…
404-geek Jul 8, 2024
563991b
reinstated deleted code during rebase nexB#1283
404-geek Jul 11, 2024
4632dfc
code formatting nexB#1283
404-geek Jul 11, 2024
923c834
database migrations for scorecard nexB#1283
404-geek Jul 11, 2024
94bfcd0
updated the scanpipe only fields nexB#1283
404-geek Jul 13, 2024
d129f73
changed scorecode commit hash for latest pull nexB#1283
404-geek Jul 13, 2024
24c7be0
Merge branch 'nexB:main' into scorecard_integration
404-geek Jul 15, 2024
259f004
update pipeline code and changed scorecode hash commit nexB#1283
404-geek Jul 15, 2024
ccd75ae
changed imports structure nexB#1283
404-geek Jul 15, 2024
9d80ef1
Merge branch 'nexB:main' into scorecard_integration
404-geek Jul 25, 2024
29da290
modified lookup and save logic nexB#1283
404-geek Jul 25, 2024
9d72734
merged migrations due to conflicts nexB#1283
404-geek Jul 27, 2024
301122e
updated migrations nexB#1283
404-geek Jul 27, 2024
5812d97
updated doc string for get_scorecard_info_packages.py nexB#1283
404-geek Jul 27, 2024
df50416
Added scorecard pipeline to SCIO with intergration test nexB#1283
404-geek Jul 28, 2024
88a43dc
Merge branch 'main' into scorecard_integration
404-geek Aug 20, 2024
fc4945e
moved the data to be regenerated if reqiured nexB#1283
404-geek Aug 20, 2024
c00b3b3
updated urls for testing nexB#1283
404-geek Aug 20, 2024
b97ff7a
added merged migration file nexB#1283
404-geek Aug 20, 2024
496945b
Changed docstring and renamed functions according to suggestions nexB…
404-geek Aug 22, 2024
f86d5bb
class name changes in steps of pipeline nexB#1283
404-geek Aug 22, 2024
36e955a
pipeline name updated nexB#1283
404-geek Aug 22, 2024
90c113a
Merge branch 'aboutcode-org:main' into scorecard_integration
404-geek Sep 22, 2024
43886a3
update pipeline code and steps nexB#1283
404-geek Sep 22, 2024
7c134c7
Merge branch 'main' into scorecard_integration
404-geek Oct 30, 2024
3d4d6ea
update pipeline steps to work with scorecode 0.0.2 release nexB#1283
404-geek Nov 1, 2024
f4ed4b5
Merge remote-tracking branch 'origin/scorecard_integration' into scor…
404-geek Nov 1, 2024
b9229a5
update migration nexB#1283
404-geek Nov 1, 2024
f80f111
Merge branch 'aboutcode-org:main' into scorecard_integration
404-geek Nov 1, 2024
ee2ea14
update migration nexB#1283
404-geek Nov 1, 2024
bd5b9b3
rename pipeline name with data parsing function nexB#1283
404-geek Nov 3, 2024
2b4629e
code valid nexB#1283
404-geek Nov 3, 2024
99ee48d
update setup.cfg nexB#1283
404-geek Nov 3, 2024
80153f8
optimize code while saving score checks nexB#1283
404-geek Nov 4, 2024
77efae0
Merge branch 'aboutcode-org:main' into scorecard_integration
404-geek Dec 2, 2024
113a557
update test cases and regen scorecard data logic nexB#1283
404-geek Dec 3, 2024
64e17fe
update migration file nexB#1283
404-geek Dec 3, 2024
027fe2d
remove unwanted change nexB#1283
404-geek Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Generated by Django 5.1.3 on 2024-12-02 22:53

import django.db.models.deletion
import uuid
from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('scanpipe', '0069_project_purl'),
]

operations = [
migrations.AlterField(
model_name='project',
name='purl',
field=models.CharField(blank=True, help_text="Package URL (PURL) for the project, required for pushing the project's scan result to FederatedCode. For example, if the input is an input URL like https://registry.npmjs.org/lodash/-/lodash-4.17.21.tgz, the corresponding PURL would be pkg:npm/[email protected].", max_length=2048),
),
Comment on lines +15 to +19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this field impacted by this PR?

migrations.CreateModel(
name='DiscoveredPackageScore',
fields=[
('scoring_tool', models.CharField(blank=True, choices=[('ossf-scorecard', 'Ossf'), ('others', 'Others')], help_text='Defines the source of a score or any other scoring metricsFor example: ossf-scorecard for scorecard data', max_length=100)),
('scoring_tool_version', models.CharField(blank=True, help_text='Defines the version of the scoring tool used for scanning thepackageFor Eg : 4.6 current version of OSSF - scorecard', max_length=50)),
('score', models.CharField(blank=True, help_text='Score of the package which is scanned', max_length=50)),
('scoring_tool_documentation_url', models.CharField(blank=True, help_text='Documentation URL of the scoring tool used', max_length=100)),
('score_date', models.DateTimeField(blank=True, editable=False, help_text='Date when the scoring was calculated on the package', null=True)),
('uuid', models.UUIDField(db_index=True, default=uuid.uuid4, editable=False, primary_key=True, serialize=False, verbose_name='UUID')),
('discovered_package', models.ForeignKey(blank=True, editable=False, help_text='The package for which the score is given', null=True, on_delete=django.db.models.deletion.CASCADE, related_name='discovered_packages_score', to='scanpipe.discoveredpackage')),
],
options={
'abstract': False,
},
),
migrations.CreateModel(
name='ScorecardCheck',
fields=[
('check_name', models.CharField(blank=True, help_text='Defines the name of check corresponding to the OSSF scoreFor example: Code-Review or CII-Best-PracticesThese are the some of the checks which are performed on a scanned package', max_length=100)),
('check_score', models.CharField(blank=True, help_text='Defines the score of the check for the package scannedFor Eg : 9 is a score given for Code-Review', max_length=50)),
('reason', models.CharField(blank=True, help_text='Gives a reason why a score was given for a specific checkFor eg, : Found 9/10 approved changesets -- score normalized to 9', max_length=300)),
('details', models.JSONField(blank=True, default=list, help_text='A list of details/errors regarding the score')),
('uuid', models.UUIDField(db_index=True, default=uuid.uuid4, editable=False, primary_key=True, serialize=False, verbose_name='UUID')),
('for_package_score', models.ForeignKey(blank=True, editable=False, help_text='The checks for which the score is given', null=True, on_delete=django.db.models.deletion.CASCADE, related_name='discovered_packages_score_checks', to='scanpipe.discoveredpackagescore')),
],
options={
'abstract': False,
},
),
]
100 changes: 100 additions & 0 deletions scanpipe/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from collections import Counter
from collections import defaultdict
from contextlib import suppress
from datetime import datetime
from itertools import groupby
from operator import itemgetter
from pathlib import Path
Expand Down Expand Up @@ -86,6 +87,8 @@
from rq.exceptions import NoSuchJobError
from rq.job import Job
from rq.job import JobStatus
from scorecode.contrib.django.models import PackageScoreMixin
from scorecode.contrib.django.models import ScorecardChecksMixin
from taggit.managers import TaggableManager
from taggit.models import GenericUUIDTaggedItemBase
from taggit.models import TaggedItemBase
Expand Down Expand Up @@ -3964,6 +3967,103 @@ def as_spdx(self):
)


class DiscoveredPackageScore(UUIDPKModel, PackageScoreMixin):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the new models to the end of the models.py file.

def __str__(self):
return self.score or str(self.uuid)

Comment on lines +3971 to +3973
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the conventions used across the existing Models:

  1. Fields
  2. class Meta
  3. str

discovered_package = models.ForeignKey(
DiscoveredPackage,
related_name="discovered_packages_score",
help_text=_("The package for which the score is given"),
on_delete=models.CASCADE,
editable=False,
blank=True,
null=True,
Comment on lines +3980 to +3981
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a DiscoveredPackageScore instance really exists without a DiscoveredPackage FK defined?

)

def parse_score_date(date_str, formats=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need unit tests for this method.

"""
Parse a date string into a timezone-aware datetime object,
or return None if parsing fails.
"""
if not formats:
formats = ["%Y-%m-%d", "%Y-%m-%dT%H:%M:%SZ"]

if date_str:
for fmt in formats:
try:
naive_datetime = datetime.strptime(date_str, fmt)
return timezone.make_aware(
naive_datetime, timezone.get_current_timezone()
)
except ValueError:
continue

# Return None if date_str is None or parsing fails
return None

@classmethod
@transaction.atomic()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is required here? We are not doing multiple database updates that could crash and needs to be handled?

Copy link
Collaborator Author

@404-geek 404-geek Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are updating the checks and score table at one go for that reason, I have kept it atomic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@404-geek Could you provide an example that shows why atomic() is useful here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@404-geek You haven't address the question above yet ;)

def create_from_scorecard_data(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing unit test for this method.

cls, discovered_package, scorecard_data, scoring_tool=None
):
"""Create ScoreCard object from scorecard data and discovered package"""
final_data = {
"score": scorecard_data.score,
"scoring_tool_version": scorecard_data.scoring_tool_version,
"scoring_tool_documentation_url": (
scorecard_data.scoring_tool_documentation_url
),
"score_date": cls.parse_score_date(scorecard_data.score_date),
}

scorecard_object = cls.objects.create(
**final_data,
discovered_package=discovered_package,
scoring_tool=scoring_tool,
)

for check in scorecard_data.checks:
ScorecardCheck.create_from_data(package_score=scorecard_object, check=check)

return scorecard_object

@classmethod
def create_from_package_and_scorecard(cls, scorecard_data, package):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing unit test for this method.

score_object = cls.create_from_scorecard_data(
discovered_package=package,
scorecard_data=scorecard_data,
scoring_tool="ossf-scorecard",
)
return score_object


class ScorecardCheck(UUIDPKModel, ScorecardChecksMixin):
def __str__(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required? Do you show this anywhere?
I don't think showing just the score/uuid is helpful at all. We need the repo + score anyway if you're logging this. But you should get the values from the objects directly where you log it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just kept it like that

Do you have anything in mind to return if someone calls the instance directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the conventions used across the existing Models:

  1. Fields
  2. class Meta
  3. str

return self.check_score or str(self.uuid)

for_package_score = models.ForeignKey(
DiscoveredPackageScore,
related_name="discovered_packages_score_checks",
help_text=_("The checks for which the score is given"),
on_delete=models.CASCADE,
editable=False,
blank=True,
null=True,
Comment on lines +4051 to +4052
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those really optional fields?

)

@classmethod
def create_from_data(cls, package_score, check):
"""Create a ScorecardCheck instance from provided data."""
return cls.objects.create(
check_name=check.check_name,
check_score=check.check_score,
reason=check.reason or "",
details=check.details or [],
for_package_score=package_score,
)


def normalize_package_url_data(purl_mapping, ignore_nulls=False):
"""
Normalize a mapping of purl data so database queries with
Expand Down
68 changes: 68 additions & 0 deletions scanpipe/pipelines/fetch_scorecode_info.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
# SPDX-License-Identifier: Apache-2.0
#
# http://nexb.com and https://github.com/nexB/scancode.io
# The ScanCode.io software is licensed under the Apache License version 2.0.
# Data generated with ScanCode.io is provided as-is without warranties.
# ScanCode is a trademark of nexB Inc.
#
# You may not use this software except in compliance with the License.
# You may obtain a copy of the License at: http://apache.org/licenses/LICENSE-2.0
# Unless required by applicable law or agreed to in writing, software distributed
# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
# CONDITIONS OF ANY KIND, either express or implied. See the License for the
# specific language governing permissions and limitations under the License.
#
# Data Generated with ScanCode.io is provided on an "AS IS" BASIS, WITHOUT WARRANTIES
# OR CONDITIONS OF ANY KIND, either express or implied. No content created from
# ScanCode.io should be considered or used as legal advice. Consult an Attorney
# for any legal advice.
#
# ScanCode.io is a free software code scanning tool from nexB Inc. and others.
# Visit https://github.com/nexB/scancode.io for support and download.


from scorecode import ossf_scorecard

from scanpipe.models import DiscoveredPackageScore
from scanpipe.pipelines import Pipeline


class FetchScoreCodeInfo(Pipeline):
"""
Fetch ScoreCode information for packages and dependencies.

This pipeline retrieves ScoreCode data for each package in the project
and stores it in the corresponding package instances.
"""

download_inputs = False
is_addon = True

@classmethod
def steps(cls):
return (
cls.check_scorecode_service_availability,
cls.fetch_packages_scorecode_info,
)

def check_scorecode_service_availability(self):
"""Check if the scorecode service is configured and available."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ScoreCode case for consistency.

if not ossf_scorecard.is_available():
raise Exception("scorecode service is not available.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ScoreCode case for consistency.


def fetch_packages_scorecode_info(self):
"""Fetch scorecode information for each of the project's discovered packages."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ScoreCode case for consistency.

for package in self.project.discoveredpackages.all():
scorecard_data = ossf_scorecard.fetch_scorecard_info(
package=package, logger=None
)

if scorecard_data:
DiscoveredPackageScore.create_from_package_and_scorecard(
scorecard_data=scorecard_data,
package=package,
)

else:
# We Want to create error instead of exception
raise Exception("No data found for the package")
9 changes: 9 additions & 0 deletions scanpipe/tests/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@
# ScanCode.io is a free software code scanning tool from nexB Inc. and others.
# Visit https://github.com/nexB/scancode.io for support and download.

import json
import os
import uuid
from datetime import datetime
from pathlib import Path
from unittest import mock

from django.apps import apps
Expand Down Expand Up @@ -284,3 +286,10 @@ def make_dependency(project, **extra):
"license_key": "mpl-2.0",
},
}

scorecard_data = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line seems unnecessary.


data = Path(__file__).parent / "data"

with open(f"{data}/scorecode/scorecard_response.json") as file:
scorecard_data = json.load(file)
Comment on lines +292 to +295
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be loaded in the module init but as needed in the test function context.

Loading