Add support for buildpack.toml files #4031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NucleonGodX
force-pushed
the
issue3477
branch
from
266b903 to
cd1ec55
Compare
NucleonGodX
changed the title
…pack package Signed-off-by: NucleonGodX <[email protected]>
Signed-off-by: NucleonGodX <[email protected]>
Signed-off-by: NucleonGodX <[email protected]>
Signed-off-by: NucleonGodX <[email protected]>
NucleonGodX
force-pushed
the
issue3477
branch
from
418fb5d to
afaba83
Compare
AyanSinhaMahapatra
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Thanks++ @NucleonGodX for the PR!
This is a great start.
See my comments for your consideration.
tests/packagedcode/data/buildpack/paketo-buildpacks/java-memory-assistant/buildpack.toml
Show resolved
Hide resolved
tests/packagedcode/data/buildpack/paketo-buildpacks/dotnet-execute/buildpack.toml
Show resolved
Hide resolved
tests/packagedcode/data/buildpack/paketo-buildpacks/opentelemetry/buildpack.toml
Show resolved
Hide resolved
| keywords = ["java", "apm", "trace", "opentelemetry"] | ||
| name = "Paketo Buildpack for OpenTelemetry" | ||
| sbom-formats = ["application/vnd.cyclonedx+json", "application/vnd.syft+json"] | ||
| version = "{{.version}}" |
There was a problem hiding this comment.
This is not useful to parse and store directly as version, check the spec for how we could deduce this
tests/packagedcode/data/buildpack/paketo-buildpacks/opentelemetry/buildpack.toml
Show resolved
Hide resolved
Signed-off-by: NucleonGodX <[email protected]>
Signed-off-by: NucleonGodX <[email protected]>
NucleonGodX
force-pushed
the
issue3477
branch
from
85b2ccd to
5399fdd
Compare
|
Thanks @AyanSinhaMahapatra for your suggestions, I've implemented them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3477
Tasks
Run tests locally to check for errors.
Signed-off-by: NucleonGodX [email protected]