Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new and updated licenses #3586

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Add new and updated licenses #3586

merged 4 commits into from
Nov 16, 2023

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Nov 16, 2023

Thanks for the new licenses and updates @DennisClark

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

These were added by @DennisClark

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #3571

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@DennisClark DennisClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyanSinhaMahapatra everything looks good, except please do not change the owner of niels-ferguson "Niels Ferguson License" to Unspecified but leave it as "Niels Ferguson". Thanks.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Copy link
Member

@DennisClark DennisClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AyanSinhaMahapatra Looks ready to deploy, thanks.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 8de1e90 into develop Nov 16, 2023
33 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the license-sync branch November 16, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants