LPD-6977 Namespace needs to only be passed to the element name attribute

Otherwise PortletRequestImpl.java#_processCheckbox won't process the checkbox correctly because checkboxNames will have a namespace and the value doesn't.
abhnerramos · Mar 21, 2024 · d686b0b · d686b0b
1 parent 57eeff9
commit d686b0b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/...-taglib-clay/src/main/java/com/liferay/frontend/taglib/clay/servlet/taglib/ToggleTag.java b/...-taglib-clay/src/main/java/com/liferay/frontend/taglib/clay/servlet/taglib/ToggleTag.java
@@ -194,7 +194,9 @@ protected Map<String, Object> prepareProps(Map<String, Object> props) {
 			props.put("type", _type);
 		}
 
-		props.put("value", _value);
+		if (Validator.isNotNull(_value)) {
+			props.put("value", _value);
+		}
 
 		if (Validator.isNotNull(_offSymbol) || Validator.isNotNull(_onSymbol)) {
 			JSONObject symbolJSONObject = JSONFactoryUtil.createJSONObject();

diff --git a/...apps/frontend-taglib/frontend-taglib-clay/src/main/resources/META-INF/resources/Toggle.js b/...apps/frontend-taglib/frontend-taglib-clay/src/main/resources/META-INF/resources/Toggle.js
@@ -17,11 +17,13 @@ export default function Toggle({
 	helpText,
 	label,
 	locale: _locale,
+	name,
 	offLabel,
 	onLabel,
 	portletId: _portletId,
 	portletNamespace: _portletNamespace,
 	toggled: _initialToggled,
+	value,
 	...otherProps
 }) {
 	const [toggled, setToggled] = useState(_initialToggled);
@@ -45,8 +47,10 @@ export default function Toggle({
 					)}
 				</>
 			}
+			name={_portletNamespace + name}
 			onToggle={setToggled}
 			toggled={toggled}
+			value={value ?? toggled ? 'on' : undefined}
 			{...otherProps}
 		/>
 	);