Upgrade http / hyper to 1.0 (axum 0.7) #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this 💪🏻 I had a branch somewhere else locally checking the necessary changes, but it looks you've made more progress here :) |
siketyan
force-pushed
the
feat/http-v1
branch
from
bc081b2 to
f84092d
Compare
siketyan
commented
Jan 14, 2024
Signed-off-by: Natsuki Ikeguchi <[email protected]>
siketyan
force-pushed
the
feat/http-v1
branch
from
f84092d to
e725b33
Compare
siketyan
changed the title
siketyan
force-pushed
the
feat/http-v1
branch
from
bf54c68 to
6554fe3
Compare
siketyan
force-pushed
the
feat/http-v1
branch
from
6554fe3 to
d165cfd
Compare
|
@abdolence Could you please review this when you have time? |
siketyan
force-pushed
the
feat/http-v1
branch
from
e7067bd to
d165cfd
Compare
|
Reviewing it right now, this is great work, @siketyan |
siketyan
commented
Jan 14, 2024
|
All looks good for now. I'm going to merge this and do a bit of testing next week, so feel free to open more fixes/PRs if something popups. Even if it breaks API, it is better to clean up now, since this will v2. Again, thanks for the PR and swift changes even for the latest updates from me 🚀 |
|
I need to update docs as well before releasing this. |
abdolence
approved these changes
Jan 14, 2024
|
This is released as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #219, #220, #222, #233