test: add more rate limit tests

aave · Jul 23, 2024 · 7312cf3 · 7312cf3
1 parent 01acca6
commit 7312cf3
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 0 deletions.
diff --git a/src/test/TestArbGhoSteward.t.sol b/src/test/TestArbGhoSteward.t.sol
@@ -150,6 +150,44 @@ contract TestArbGhoSteward is TestGhoBase {
     );
   }
 
+  function testRevertUpdateRateLimitToZero() public {
+    RateLimiter.Config memory invalidConfig = RateLimiter.Config({
+      isEnabled: true,
+      capacity: 0,
+      rate: 0
+    });
+    vm.prank(RISK_COUNCIL);
+    vm.expectRevert();
+    ARB_GHO_STEWARD.updateRateLimit(
+      2,
+      invalidConfig.isEnabled,
+      invalidConfig.capacity,
+      invalidConfig.rate,
+      rateLimitConfig.isEnabled,
+      rateLimitConfig.capacity,
+      rateLimitConfig.rate
+    );
+  }
+
+  function testRevertUpdateRateLimitRateGreaterThanCapacity() public {
+    RateLimiter.Config memory invalidConfig = RateLimiter.Config({
+      isEnabled: true,
+      capacity: 10,
+      rate: 100
+    });
+    vm.prank(RISK_COUNCIL);
+    vm.expectRevert();
+    ARB_GHO_STEWARD.updateRateLimit(
+      2,
+      invalidConfig.isEnabled,
+      invalidConfig.capacity,
+      invalidConfig.rate,
+      rateLimitConfig.isEnabled,
+      rateLimitConfig.capacity,
+      rateLimitConfig.rate
+    );
+  }
+
   function testUpdateFacilitatorBucketCapacity() public {
     (uint256 currentBucketCapacity, ) = GHO_TOKEN.getFacilitatorBucket(address(GHO_ATOKEN));
     vm.prank(RISK_COUNCIL);

diff --git a/src/test/TestGhoStewardV2.t.sol b/src/test/TestGhoStewardV2.t.sol
@@ -894,6 +894,44 @@ contract TestGhoStewardV2 is TestGhoBase {
     );
   }
 
+  function testRevertUpdateRateLimitToZero() public {
+    RateLimiter.Config memory invalidConfig = RateLimiter.Config({
+      isEnabled: true,
+      capacity: 0,
+      rate: 0
+    });
+    vm.prank(RISK_COUNCIL);
+    vm.expectRevert();
+    GHO_STEWARD_V2.updateRateLimit(
+      2,
+      invalidConfig.isEnabled,
+      invalidConfig.capacity,
+      invalidConfig.rate,
+      rateLimitConfig.isEnabled,
+      rateLimitConfig.capacity,
+      rateLimitConfig.rate
+    );
+  }
+
+  function testRevertUpdateRateLimitRateGreaterThanCapacity() public {
+    RateLimiter.Config memory invalidConfig = RateLimiter.Config({
+      isEnabled: true,
+      capacity: 10,
+      rate: 100
+    });
+    vm.prank(RISK_COUNCIL);
+    vm.expectRevert();
+    GHO_STEWARD_V2.updateRateLimit(
+      2,
+      invalidConfig.isEnabled,
+      invalidConfig.capacity,
+      invalidConfig.rate,
+      rateLimitConfig.isEnabled,
+      rateLimitConfig.capacity,
+      rateLimitConfig.rate
+    );
+  }
+
   function testSetControlledFacilitatorAdd() public {
     address[] memory oldControlledFacilitators = GHO_STEWARD_V2.getControlledFacilitators();
     address[] memory newGsmList = new address[](1);