Revert Optional in Embedded_data_specification #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #328, we made the attribute `data_specification` in class `Embedded_data_specification` optional, since that is what we thought the specification said (See also the discussion in #326) However, this was a bug in the specification, which is fixed in v3.0.1 of the specification. We therefore revert these changes. Fixes #326
|
@s-heppner let's discuss the status of this change in a call? I think there is a huge confision rolling on between the gap between the book(s), schemas, SDKs and so on. |
|
We decided on collecting the changes in a new branch (V3.0.1/main) |
Merged
s-heppner
added a commit
that referenced
this pull request
Oct 28, 2024
In #328, we had erroneously made `Embedded_data_specification.data_specification` optional, changing the order of the attributes of this class, as optional attributes have to be specified after mandatory ones. In #329, we reverted the `Optional`, but kept the order of the attributes, as this didn't affect our code. However, as a result, the generated schema files that depend on the order of the attributes were suddenly not backward compatible anymore, as found in [aas-specs#477]. This reverts the order of the attributes in class `Embedded_data_specification`. [aas-specs#477]: admin-shell-io/aas-specs#477
This was referenced Oct 28, 2024
mristin
pushed a commit
that referenced
this pull request
Oct 30, 2024
In #328, we had erroneously made `Embedded_data_specification.data_specification` optional, changing the order of the attributes of this class, as optional attributes have to be specified after mandatory ones. In #329, we reverted the `Optional`, but kept the order of the attributes, as this didn't affect our code. However, as a result, the generated schema files that depend on the order of the attributes were suddenly not backward compatible anymore, as found in [aas-specs#477]. This reverts the order of the attributes in class `Embedded_data_specification`. [aas-specs#477]: admin-shell-io/aas-specs#477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #328, we made the attribute
data_specificationin classEmbedded_data_specificationoptional,since that is what we thought the specification said.
(See also the discussion in #326)
However, this was a bug in the specification, which is fixed
in v3.0.1 of the specification.
We therefore revert these changes.
Fixes #326